Extend the mDNS package with a native extension used on Mac OS

Extend the mDNS package with a native extension used on Mac OS

On Mac OS the mDNSResponder daemon has opened port 5353
exclusively. Therefore it is not possible to speak the mDNS protocol
from Dart using datagram sockets.

The native extension uses the Mac OS DNS Service Discovery C API.

Updated the copyright notice to use Fletch instead of Dart.

BUG= https://github.com/dart-lang/fletch/issues/225
R=karlklose@google.com, ricow@google.com

Committed: https://github.com/dart-lang/fletch/commit/7b02aeda7e019a7daa08b2002be956150aaae4e2

[Søren Gjesse, 2015-10-29 21:25:20]

Description was changed from

==========
Extend the mDNS package with a native extension used on Mac OS

On Mac OS the mDNSResponder daemon has opened port 5353
exclusively. Therefore it is not possible to speak the mDNS protocol
from Dart using datagram sockets.

The native extension uses the Mac OS DNS Service Discovery C API.

R=karlklose@google.com, ricow@google.com

XXX

BUG=
==========

to

==========
Extend the mDNS package with a native extension used on Mac OS

On Mac OS the mDNSResponder daemon has opened port 5353
exclusively. Therefore it is not possible to speak the mDNS protocol
from Dart using datagram sockets.

The native extension uses the Mac OS DNS Service Discovery C API.

R=karlklose@google.com, ricow@google.com
==========

[Søren Gjesse, 2015-10-30 09:23:51]

Description was changed from

==========
Extend the mDNS package with a native extension used on Mac OS

On Mac OS the mDNSResponder daemon has opened port 5353
exclusively. Therefore it is not possible to speak the mDNS protocol
from Dart using datagram sockets.

The native extension uses the Mac OS DNS Service Discovery C API.

R=karlklose@google.com, ricow@google.com
==========

to

==========
Extend the mDNS package with a native extension used on Mac OS

On Mac OS the mDNSResponder daemon has opened port 5353
exclusively. Therefore it is not possible to speak the mDNS protocol
from Dart using datagram sockets.

The native extension uses the Mac OS DNS Service Discovery C API.

Updated the copyright notice to use Fletch instead of Dart.

R=karlklose@google.com, ricow@google.com
==========

[ricow1, 2015-10-30 10:28:33]

lgtm

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/.gitignore
File pkg/mdns/.gitignore (right):

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/.gitignore#new...
pkg/mdns/.gitignore:1: lib/native/libmdns_extension_lib.so
we add all gitignore in the top level file

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/lib/src/native...
File pkg/mdns/lib/src/native_extension_client.dart (right):

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/lib/src/native...
pkg/mdns/lib/src/native_extension_client.dart:32: Future start() async {
this does not return a future

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/lib/src/native...
pkg/mdns/lib/src/native_extension_client.dart:76: if (response is List &&
response.length == 2) {
should we do something different if we get a non working response? log it
somewhere? Also, maybe add a comment with a description of the structure

[karlklose, 2015-10-30 11:17:15]

Dart and C++ LGTM. Maybe add a TODO to handle the case where no response is
received.

[Søren Gjesse, 2015-10-30 12:13:16]

Added TODO about timeout.

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/.gitignore
File pkg/mdns/.gitignore (right):

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/.gitignore#new...
pkg/mdns/.gitignore:1: lib/native/libmdns_extension_lib.so
On 2015/10/30 10:28:33, ricow1 wrote:
> we add all gitignore in the top level file

Done.

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/lib/src/native...
File pkg/mdns/lib/src/native_extension_client.dart (right):

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/lib/src/native...
pkg/mdns/lib/src/native_extension_client.dart:32: Future start() async {
On 2015/10/30 10:28:33, ricow1 wrote:
> this does not return a future

It is "async", so it does.

https://codereview.chromium.org/1407123010/diff/80001/pkg/mdns/lib/src/native...
pkg/mdns/lib/src/native_extension_client.dart:76: if (response is List &&
response.length == 2) {
On 2015/10/30 10:28:33, ricow1 wrote:
> should we do something different if we get a non working response? log it
> somewhere? Also, maybe add a comment with a description of the structure

Added a print for errors for now.

Documented the response.

[Søren Gjesse, 2015-10-30 13:25:17]

Description was changed from

==========
Extend the mDNS package with a native extension used on Mac OS

On Mac OS the mDNSResponder daemon has opened port 5353
exclusively. Therefore it is not possible to speak the mDNS protocol
from Dart using datagram sockets.

The native extension uses the Mac OS DNS Service Discovery C API.

Updated the copyright notice to use Fletch instead of Dart.

R=karlklose@google.com, ricow@google.com
==========

to

==========
Extend the mDNS package with a native extension used on Mac OS

On Mac OS the mDNSResponder daemon has opened port 5353
exclusively. Therefore it is not possible to speak the mDNS protocol
from Dart using datagram sockets.

The native extension uses the Mac OS DNS Service Discovery C API.

Updated the copyright notice to use Fletch instead of Dart.

BUG= https://github.com/dart-lang/fletch/issues/225

R=karlklose@google.com, ricow@google.com
==========

[Søren Gjesse, 2015-11-02 08:06:24]

Committed patchset #6 (id:100001) manually as
7b02aeda7e019a7daa08b2002be956150aaae4e2.