mac: Stop using __weak.

chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_MENU_BUBBLE_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_MENU_BUBBLE_CONTROLLER_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_nsobject.h"
@@ skipping 37 matching lines @@
 - (IBAction)switchProfile:(id)sender;
 
 @end
 
 ////////////////////////////////////////////////////////////////////////////////
 
 // This view controller manages the menu item XIB.
 @interface AvatarMenuItemController : NSViewController<NSAnimationDelegate> {
  @private
   // The parent menu controller; owns this.
-  __weak AvatarMenuBubbleController* controller_;
+  AvatarMenuBubbleController* controller_;  // weak
 
   // The index of the item in the AvatarMenu.
   size_t menuIndex_;
 
   // Tracks whether this item is currently highlighted.
   BOOL isHighlighted_;
 
   // The animation showing the edit link, which is run after the user has
   // dwelled over the item for a short delay.
   base::scoped_nsobject<NSAnimation> linkAnimation_;
 
   // Instance variables that back the outlets.
-  __weak NSImageView* iconView_;
-  __weak NSImageView* activeView_;
-  __weak NSTextField* nameField_;
+  NSImageView* iconView_;
+  NSImageView* activeView_;
+  NSTextField* nameField_;
   // These two views sit on top of each other, and only one is visible at a
   // time. The editButton_ is visible when the mouse is over the item and the
   // emailField_ is visible otherwise.
-  __weak NSTextField* emailField_;
-  __weak NSButton* editButton_;
+  NSTextField* emailField_;
+  NSButton* editButton_;
 }
 @property(readonly, nonatomic) size_t menuIndex;
 @property(assign, nonatomic) BOOL isHighlighted;
-@property(assign, nonatomic) IBOutlet NSImageView* iconView;
-@property(assign, nonatomic) IBOutlet NSImageView* activeView;
-@property(assign, nonatomic) IBOutlet NSTextField* nameField;
-@property(assign, nonatomic) IBOutlet NSTextField* emailField;
-@property(assign, nonatomic) IBOutlet NSButton* editButton;
+@property(readonly, nonatomic) IBOutlet NSImageView* iconView;

[Robert Sesek, 2015/11/03 15:41:11]

Why the change from assign -> readonly? That doesn't seem right given the
IBOutlet annotation.

[Nico, 2015/11/03 16:01:18]

It can't stay assign without the __weak. I could change it to retain, but since
they're never changed after being loaded from the nib this seemed like the
semantically better choice.

[Robert Sesek, 2015/11/03 22:03:51]

If they're now retained, won't they be leaked? (Maybe use ObjCPropertyReleaser
?)

[Nico, 2015/11/03 22:15:58]

Done.

+@property(readonly, nonatomic) IBOutlet NSImageView* activeView;
+@property(readonly, nonatomic) IBOutlet NSTextField* nameField;
+@property(readonly, nonatomic) IBOutlet NSTextField* emailField;
+@property(readonly, nonatomic) IBOutlet NSButton* editButton;
 
 // Designated initializer.
 - (id)initWithMenuIndex:(size_t)menuIndex
           menuController:(AvatarMenuBubbleController*)controller;
 
 // Actions that are forwarded to the |controller_|.
 - (IBAction)switchToProfile:(id)sender;
 - (IBAction)editProfile:(id)sender;
 
 // Highlights the subviews appropriately for a given event type from the switch
 // profile button.
 - (void)highlightForEventType:(NSEventType)type;
 
 @end
 
 ////////////////////////////////////////////////////////////////////////////////
 
 // Simple button cell to get tracking and mouse events forwarded back to the
 // view controller for changing highlight style of the item subviews. This is
 // an invisible button that underlays most of the menu item and is responsible
 // for performing the switch profile action.
 @interface AvatarMenuItemView : NSView {
  @private
   // The controller that manages this.
-  __weak AvatarMenuItemController* viewController_;
+  // weak to not form a reference cycle with the controller.
+  __unsafe_unretained AvatarMenuItemController* viewController_;
 
   // Used to highlight the background on hover.
   ui::ScopedCrTrackingArea trackingArea_;
 }
 @property(assign, nonatomic) IBOutlet AvatarMenuItemController* viewController;
 @end
 
 ////////////////////////////////////////////////////////////////////////////////
 
 @interface AccessibilityIgnoredImageCell : NSImageCell
@@ skipping 10 matching lines @@
          anchoredAt:(NSPoint)point;
 - (void)performLayout;
 - (NSMutableArray*)items;
 @end
 
 @interface AvatarMenuItemController (ExposedForTesting)
 - (void)willStartAnimation:(NSAnimation*)animation;
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_MENU_BUBBLE_CONTROLLER_H_