Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1407103002: Make enum values array canonical (Closed)

Created:
5 years, 2 months ago by hausner
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : wip #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M runtime/vm/class_finalizer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/enum_test.dart View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
hausner
5 years, 2 months ago (2015-10-15 21:53:35 UTC) #2
rmacnak
https://codereview.chromium.org/1407103002/diff/20001/tests/language/enum_test.dart File tests/language/enum_test.dart (right): https://codereview.chromium.org/1407103002/diff/20001/tests/language/enum_test.dart#newcode25 tests/language/enum_test.dart:25: Expect.identical(const [Enum2.A], Enum2.values); (sigh, generics) Specs says this should ...
5 years, 2 months ago (2015-10-15 22:20:21 UTC) #3
rmacnak
On 2015/10/15 22:20:21, rmacnak wrote: > https://codereview.chromium.org/1407103002/diff/20001/tests/language/enum_test.dart > File tests/language/enum_test.dart (right): > > https://codereview.chromium.org/1407103002/diff/20001/tests/language/enum_test.dart#newcode25 > ...
5 years, 2 months ago (2015-10-15 22:34:31 UTC) #4
hausner
Thanks https://codereview.chromium.org/1407103002/diff/20001/tests/language/enum_test.dart File tests/language/enum_test.dart (right): https://codereview.chromium.org/1407103002/diff/20001/tests/language/enum_test.dart#newcode25 tests/language/enum_test.dart:25: Expect.identical(const [Enum2.A], Enum2.values); On 2015/10/15 22:20:21, rmacnak wrote: ...
5 years, 2 months ago (2015-10-15 22:53:01 UTC) #5
hausner
5 years, 2 months ago (2015-10-15 22:56:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
647ada25ed6f6ec745fd5e5885cbeb53c3741b1c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698