Source/modules/websockets/MainThreadWebSocketChannel.h - Issue 14071008: WebSocket object should fire error event when WebSocket server can't be connected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/MainThreadWebSocketChannel.h

Issue 14071008: WebSocket object should fire error event when WebSocket server can't be connected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Add new layouttests into TestExceptions because it depends on chromium side patch Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/network/chromium/SocketStreamHandle.cpp ('k') | Source/modules/websockets/MainThreadWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/MainThreadWebSocketChannel.h

diff --git a/Source/modules/websockets/MainThreadWebSocketChannel.h b/Source/modules/websockets/MainThreadWebSocketChannel.h

index 5290cbb33227e10a9498e29cd74c59b32c9f1eb2..70d8f9cad7413e879b5b96a2837fa05783dfa648 100644

--- a/Source/modules/websockets/MainThreadWebSocketChannel.h

+++ b/Source/modules/websockets/MainThreadWebSocketChannel.h

@@ -174,6 +174,7 @@ private:

Timer<MainThreadWebSocketChannel> m_resumeTimer;

bool m_suspended;

bool m_closing;

+ bool m_didFailOfClientAlreadyRun;

bool m_receivedClosingHandshake;

Timer<MainThreadWebSocketChannel> m_closingTimer;

bool m_closed;