WebSocket object should fire error event when WebSocket server can't be connected.

Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp

Index: Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp
diff --git a/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp b/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp
index 59e4181abf0addfec01b09129ab119e30e6be980..8cde1598640efb1dec27efd8077317b7632e8b2b 100644
--- a/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp
+++ b/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp
@@ -29,6 +29,7 @@
  */
 
 #include "config.h"
+#include "SocketStreamError.h"
 #include "SocketStreamHandle.h"
 #include "SocketStreamHandleInternal.h"
 
@@ -37,6 +38,7 @@
 #include "SocketStreamHandleClient.h"
 #include <public/Platform.h>
 #include <public/WebData.h>
+#include <public/WebSocketStreamError.h>
 #include <public/WebSocketStreamHandle.h>
 #include <wtf/PassOwnPtr.h>
 
@@ -153,11 +155,8 @@ void SocketStreamHandleInternal::didFail(WebKit::WebSocketStreamHandle* socketHa
     LOG(Network, "SocketStreamHandleInternal %p didFail()", this);
     if (m_handle && m_socket) {
         ASSERT(socketHandle == m_socket.get());
-        m_socket.clear();
-        SocketStreamHandle* h = m_handle;
-        m_handle = 0;
-        if (h->m_client)
-            h->m_client->didCloseSocketStream(h); // didFail(h, err);
+        if (m_handle->m_client)
+            m_handle->m_client->didFailSocketStream(m_handle, *(PassRefPtr<SocketStreamError>(err)));

[tyoshino (SeeGerritForStatus), 2013/04/17 13:50:10]

i'm not 100% sure if we can choose not to do the same as didClose (save
m_handle, clear it and then call the did.* method). Could you please do that for
now maybe with FIXME: just use m_handle?

[Li Yin, 2013/04/18 07:03:03]

didClose will be always invoked at the end. So clear m_handle should be done in
the didClose function, but not in didFail.

About "Could you please do that for now maybe with FIXME: just use m_handle?"
Sorry, I can't catch your point.

[tyoshino (SeeGerritForStatus), 2013/04/18 08:29:59]

I was trying to remember why m_handle is set to 0 in didClose() before calling
didCloseSocketStream(), but couldn't. Neither the review log nor change log have
any discussion for this code.

WebSocketChannel::didCloseSocketStream() resets WebSocketChannel::m_handle, and
then, SocketStreamHandle loses reference counts, and SocketStreamHandleInternal
owned by SocketStreamHandle also goes away.

I believe L146-149 is related to this destruction chain, but not sure...
Resetting SocketStreamHandleInternal::m_handle just prevents
SocketStreamHandleInternal::did.*() methods to touch the SocketStreamHandle
instance, but when SocketStreamHandle is dead, this class is also dead. So,
touching this->m_handle is bad at all. We should rather prevent m_socket from
touching this instance. WebSocketStreamHandle is also in the same boat...
I meant to ask you to do the same as L146-149 here just to be safe. But I was
wrong. Never mind.

Now this method (didFail) is calling didFailSocketStream. Not
didCloseSocketStream. didFailSocketStream doesn't reset
WebSocketChannel::m_handle. SocketStreamHandleInternal::didClose must also get
called later, so we shouldn't reset m_handle here.

Again, please never mind this comment. Sorry.

     }
 }