Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3455)

Unified Diff: chrome/browser/metrics/first_web_contents_profiler.h

Issue 1407093003: Add start/finish navigation to startup metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a2_better_ownership_model_firstwebcontentsprofiler
Patch Set: review:clamy => simpler == better :-) Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/first_web_contents_profiler.h
diff --git a/chrome/browser/metrics/first_web_contents_profiler.h b/chrome/browser/metrics/first_web_contents_profiler.h
index 832d55539165642601e13c74422136012096a31a..1a53166d564e8fbb625557437a2b057b74342580 100644
--- a/chrome/browser/metrics/first_web_contents_profiler.h
+++ b/chrome/browser/metrics/first_web_contents_profiler.h
@@ -37,7 +37,9 @@ class FirstWebContentsProfiler : public content::WebContentsObserver {
// Abandon if the content is destroyed.
ABANDON_CONTENT_DESTROYED = 3,
// Abandon if the WebContents navigates away from its initial page.
- ABANDON_NAVIGATION = 4,
+ ABANDON_NEW_NAVIGATION = 4,
+ // Abandon if the WebContents fails to load (e.g. network error, etc.).
+ ABANDON_NAVIGATION_ERROR = 5,
ENUM_MAX
};
@@ -47,12 +49,18 @@ class FirstWebContentsProfiler : public content::WebContentsObserver {
// content::WebContentsObserver:
void DidFirstVisuallyNonEmptyPaint() override;
void DocumentOnLoadCompletedInMainFrame() override;
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
void NavigationEntryCommitted(
const content::LoadCommittedDetails& load_details) override;
void WasHidden() override;
void WebContentsDestroyed() override;
- // Whether this instance has finished collecting all of its metrics.
+ // Whether this instance has finished collecting first-paint and main-frame-
+ // load metrics (navigation metrics are recorded on a best effort but don't
+ // prevent the FirstWebContentsProfiler from calling it).
bool IsFinishedCollectingMetrics();
// Logs |finish_reason| to UMA and deletes this FirstWebContentsProfiler.
@@ -72,6 +80,12 @@ class FirstWebContentsProfiler : public content::WebContentsObserver {
// Whether an attempt was made to collect the "MainFrameLoad" metric.
bool collected_load_metric_;
+ // Whether an attempt was made to collect the "MainNavigationStart" metric.
+ bool collected_main_navigation_start_metric_;
+
+ // Whether an attempt was made to collect the "MainNavigationFinished" metric.
+ bool collected_main_navigation_finished_metric_;
+
// Histogram that keeps track of response times for the watched thread.
base::HistogramBase* responsiveness_histogram_;

Powered by Google App Engine
This is Rietveld 408576698