Add start/finish navigation to startup metrics.

chrome/browser/metrics/first_web_contents_profiler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(OS_ANDROID)
 
 #include "chrome/browser/metrics/first_web_contents_profiler.h"
 
 #include <string>
 
 #include "base/location.h"
+#include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/process/process_info.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "components/metrics/profiler/tracking_synchronizer.h"
 #include "components/metrics/proto/profiler_event.pb.h"
 #include "components/startup_metric_utils/startup_metric_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/navigation_details.h"
+#include "content/public/browser/navigation_handle.h"
 
 namespace {
 
 // The initial delay for responsiveness prober in milliseconds.
 const int kInitialDelayMs = 20;
 
 // The following is the multiplier is used to delay the probe for
 // responsiveness.
 const double kBackoffMultiplier = 1.5;
 
@@ skipping 78 matching lines @@
   return nullptr;
 }
 
 FirstWebContentsProfiler::FirstWebContentsProfiler(
     content::WebContents* web_contents,
     Delegate* delegate)
     : content::WebContentsObserver(web_contents),
       initial_entry_committed_(false),
       collected_paint_metric_(false),
       collected_load_metric_(false),
+      collected_main_navigation_start_metric_(false),
+      collected_main_navigation_finished_metric_(false),
       delegate_(delegate),
       responsiveness_histogram_(NULL),
       responsiveness_1sec_histogram_(NULL),
       responsiveness_10sec_histogram_(NULL),
       unresponsiveness_histogram_(NULL),
       unresponsiveness_1sec_histogram_(NULL),
       unresponsiveness_10sec_histogram_(NULL) {
   InitHistograms();
 }
 
@@ skipping 43 matching lines @@
     return;
   }
 
   collected_load_metric_ = true;
   startup_metric_utils::RecordFirstWebContentsMainFrameLoad(base::Time::Now());
 
   if (IsFinishedCollectingMetrics())
     FinishedCollectingMetrics(FinishReason::DONE);
 }
 
+void FirstWebContentsProfiler::DidStartNavigation(
+    content::NavigationHandle* navigation_handle) {
+  if (collected_main_navigation_start_metric_)
+    return;
+  if (startup_metric_utils::WasNonBrowserUIDisplayed()) {
+    FinishedCollectingMetrics(FinishReason::ABANDON_BLOCKING_UI);
+    return;
+  }
+
+  // The first navigation has to be the main frame's.
+  DCHECK(navigation_handle->IsInMainFrame());
+
+  collected_main_navigation_start_metric_ = true;
+  startup_metric_utils::RecordFirstWebContentsMainNavigationStart(
+      base::Time::Now());
+}
+
+void FirstWebContentsProfiler::DidFinishNavigation(
+    content::NavigationHandle* navigation_handle) {
+  if (collected_main_navigation_finished_metric_)
+    return;
+  if (startup_metric_utils::WasNonBrowserUIDisplayed()) {
+    FinishedCollectingMetrics(FinishReason::ABANDON_BLOCKING_UI);
+    return;
+  }
+
+  // The first navigation has to be the main frame's.
+  DCHECK(navigation_handle->IsInMainFrame());
+
+  if (!navigation_handle->HasCommitted() ||
+      navigation_handle->IsErrorPage()) {
+    FinishedCollectingMetrics(FinishReason::ABANDON_NAVIGATION_ERROR);
+    return;
+  }
+
+  collected_main_navigation_finished_metric_ = true;
+  startup_metric_utils::RecordFirstWebContentsMainNavigationFinished(
+      base::Time::Now());
+}
+
 void FirstWebContentsProfiler::NavigationEntryCommitted(

[clamy, 2015/10/28 11:55:59]

I think this can be merged inside DidFinishNavigation:
void FirstWebContentsProfiler::DidFinishNavigation(
 if (collected_main_navigation_finished_metric_) {
   if (navigation_handle->HasCommitted() &&
       !navigation_handle->IsSamePage()) {
     FinishedCollectingMetrics(FinishReason::ABANDON_NEW_NAVIGATION);
   }
   return;
 }
...

This should also allow to get rid of initial_entry_committed_.

[gab, 2015/10/28 20:17:38]

Awesome, done :-)! (also added IsMainFrame() to the check which I think is
required to not trigger on follow-up sub-navigations finishing)

Curious, what does IsSamePage() mean? The method's documentation is not clear to
me (i.e. I tried refreshing a page and clicking on a link to self in a test
page, both times FinishReason::ABANDON_NEW_NAVIGATION triggered (as desired) but
I expected the !IsSamePage() check to skip those).

[Charlie Reis, 2015/10/28 20:58:26]

IsSamePage means you haven't left the current document, such as fragment
navigations (#foo), pushState, replaceState, etc.  Reloads don't count because
they cause the document to be replaced (with a new one from the same URL).

clamy@, maybe you could clarify that in navigation_handle.h?

     const content::LoadCommittedDetails& load_details) {
   // Abandon profiling on any navigation to a different page as it:
   //   (1) is no longer a fair timing; and
   //   (2) can cause http://crbug.com/525209 where one of the timing heuristics
   //       (e.g. first paint) didn't fire for the initial content but fires
   //       after a lot of idle time when the user finally navigates to another
   //       page that does trigger it.
   if (load_details.is_navigation_to_different_page()) {
     if (initial_entry_committed_)
-      FinishedCollectingMetrics(FinishReason::ABANDON_NAVIGATION);
+      FinishedCollectingMetrics(FinishReason::ABANDON_NEW_NAVIGATION);
     else
       initial_entry_committed_ = true;
   }
 }
 
 void FirstWebContentsProfiler::WasHidden() {
   // Stop profiling if the content gets hidden as its load may be deprioritized
   // and timing it becomes meaningless.
   FinishedCollectingMetrics(FinishReason::ABANDON_CONTENT_HIDDEN);
 }
@@ skipping 58 matching lines @@
       100, base::Histogram::kUmaTargetedHistogramFlag);
 
   const std::string unresponsiveness_10sec_histogram_name =
       "Startup.FirstWebContents.UINotResponsive_10sec";
   unresponsiveness_10sec_histogram_ = base::Histogram::FactoryTimeGet(
       unresponsiveness_10sec_histogram_name,
       base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromSeconds(60),
       100, base::Histogram::kUmaTargetedHistogramFlag);
 }
 #endif  // !defined(OS_ANDROID)