Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407073002: Adds GetDisplays() to WindowManager (Closed)

Created:
5 years, 2 months ago by sky
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, tfarina, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds GetDisplays() to WindowManager And removes hacks that were necessitated without it. I also added a converter from a std::string to a URLRequestPtr as I got tired of creating the URLRequestPtr, then setting url. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/bbcf04ebcf7a83dd6b93c451fc2d811c8aea8cc6 Cr-Commit-Position: refs/heads/master@{#354392}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix windows #

Patch Set 4 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -91 lines) Patch
M components/html_viewer/global_state.cc View 3 chunks +16 lines, -5 lines 0 comments Download
M components/html_viewer/run_all_unittests.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M components/mus/example/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/example/common/mus_views_init.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/example/common/mus_views_init.cc View 1 2 2 chunks +66 lines, -6 lines 0 comments Download
M components/mus/example/views_examples/views_examples_application_delegate.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M components/mus/example/window_type_launcher/window_type_launcher.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/mus/example/wm/window_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/example/wm/window_manager_impl.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M components/mus/mus_app.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 2 chunks +17 lines, -0 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M components/resource_provider/resource_provider_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_application.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + mojo/converters/network/BUILD.gn View 1 chunk +6 lines, -8 lines 0 comments Download
A mojo/converters/network/network_type_converters.h View 1 chunk +21 lines, -0 lines 0 comments Download
A mojo/converters/network/network_type_converters.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M ui/mojo/init/screen_mojo.h View 3 chunks +5 lines, -6 lines 0 comments Download
M ui/mojo/init/screen_mojo.cc View 3 chunks +23 lines, -13 lines 0 comments Download
M ui/mojo/init/ui_init.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/mojo/init/ui_init.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/aura_init.h View 3 chunks +15 lines, -5 lines 0 comments Download
M ui/views/mus/aura_init.cc View 4 chunks +27 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sky
5 years, 2 months ago (2015-10-15 21:20:21 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 2 months ago (2015-10-15 21:38:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407073002/20001
5 years, 2 months ago (2015-10-15 21:40:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407073002/40001
5 years, 2 months ago (2015-10-15 21:57:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/110229)
5 years, 2 months ago (2015-10-15 22:14:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407073002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407073002/60001
5 years, 2 months ago (2015-10-15 22:18:32 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-15 23:08:03 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 23:08:45 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/bbcf04ebcf7a83dd6b93c451fc2d811c8aea8cc6
Cr-Commit-Position: refs/heads/master@{#354392}

Powered by Google App Engine
This is Rietveld 408576698