Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc

Issue 1407063006: Report initial CustomTab navigation with client package name to DataUseTabUIManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@freighterSnackbar
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/data_usage/data_use_tab_ui_manager_android.h" 5 #include "chrome/browser/android/data_usage/data_use_tab_ui_manager_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "chrome/browser/profiles/profile_android.h" 8 #include "chrome/browser/profiles/profile_android.h"
9 #include "jni/DataUseTabUIManager_jni.h" 9 #include "jni/DataUseTabUIManager_jni.h"
10 10
(...skipping 12 matching lines...) Expand all
23 jboolean IsDataUseSessionExiting(JNIEnv* env, 23 jboolean IsDataUseSessionExiting(JNIEnv* env,
24 const JavaParamRef<jclass>& clazz, 24 const JavaParamRef<jclass>& clazz,
25 jint tab_id, 25 jint tab_id,
26 const JavaParamRef<jobject>& jprofile) { 26 const JavaParamRef<jobject>& jprofile) {
27 // TODO(megjablon): Get the DataUseTabUIManager which is a keyed service and 27 // TODO(megjablon): Get the DataUseTabUIManager which is a keyed service and
28 // ask it if the data use session is exiting. 28 // ask it if the data use session is exiting.
29 // Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile); 29 // Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
30 return false; 30 return false;
31 } 31 }
32 32
33 // static
34 void CustomTabIsLoadingURL(JNIEnv* env,
bengr 2015/11/05 23:50:24 Coordinate with tbansal on the name, but it should
megjablon 2015/11/06 01:30:43 Renamed. @tbansal you good with this name? What do
tbansal1 2015/11/06 01:36:22 Name sgtm. url is needed because combination of pa
35 const JavaParamRef<jclass>& clazz,
36 jint tab_id,
37 const JavaParamRef<jstring>& packageName,
38 const JavaParamRef<jobject>& jprofile) {
39 // TODO(megjablon): Get the DataUseTabUIManager which is a keyed service and
40 // tell it about the custom tab package.
41 }
42
33 bool RegisterDataUseTabUIManager(JNIEnv* env) { 43 bool RegisterDataUseTabUIManager(JNIEnv* env) {
34 return RegisterNativesImpl(env); 44 return RegisterNativesImpl(env);
35 } 45 }
OLDNEW
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698