SkPDF: images support 32-but-not-N32 colortype

SkPDF: images support 32-but-not-N32 colortype

BUG=550559
Committed: https://skia.googlesource.com/skia/+/aa4ba90792a99eed96ac51006bd478d453a751c4

[hal.canary, 2015-11-02 22:19:16]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-02 22:19:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407063005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407063005/1

[hal.canary, 2015-11-02 22:26:58]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-02 22:27:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407063005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407063005/20001

[hal.canary, 2015-11-02 22:32:45]

Description was changed from

==========
SkPDF: images support 32-but-not-N32 colortype
==========

to

==========
SkPDF: images support 32-but-not-N32 colortype

BUG=550559
==========

[hal.canary, 2015-11-02 22:33:29]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2015-11-02 22:33:29]

PTAL

[commit-bot: I haz the power, 2015-11-02 22:37:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 22:37:51]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-11-03 12:41:03]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-11-03 12:41:03]

reed@google.com changed required reviewers:
+ reed@google.com

[reed1, 2015-11-03 12:41:04]

I'd like the chance to ponder this a little

[hal.canary, 2015-11-03 15:13:04]

On 2015/11/03 12:41:04, reed1 wrote:
> I'd like the chance to ponder this a little

Also: I need to add a GM.

[hal.canary, 2015-11-03 23:07:33]

On 2015/11/03 at 12:41:04, reed wrote:
> I'd like the chance to ponder this a little

Is this better?

[hal.canary, 2015-11-05 18:07:43]

ping

[tomhudson, 2015-11-05 22:32:11]

Sorry, was waiting for Mike. This LGTM.

https://codereview.chromium.org/1407063005/diff/70001/src/pdf/SkPDFBitmap.cpp
File src/pdf/SkPDFBitmap.cpp (right):

https://codereview.chromium.org/1407063005/diff/70001/src/pdf/SkPDFBitmap.cpp...
src/pdf/SkPDFBitmap.cpp:62: inline bool SkIsBGRA(SkColorType ct) {
nit: static or anonymous namespace for these?

[hal.canary, 2015-11-05 23:22:13]

On 2015/11/05 at 22:32:11, tomhudson wrote:
> Sorry, was waiting for Mike. This LGTM.

I'm still waiting on Mike.

https://codereview.chromium.org/1407063005/diff/70001/src/pdf/SkPDFBitmap.cpp
File src/pdf/SkPDFBitmap.cpp (right):

https://codereview.chromium.org/1407063005/diff/70001/src/pdf/SkPDFBitmap.cpp...
src/pdf/SkPDFBitmap.cpp:62: inline bool SkIsBGRA(SkColorType ct) {
On 2015/11/05 at 22:32:11, tomhudson wrote:
> nit: static or anonymous namespace for these?

Done.

[reed1, 2015-11-06 15:11:23]

lgtm

[hal.canary, 2015-11-06 15:13:00]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-11-06 15:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1407063005/#ps90001
(title: "2015-11-05 (Thursday) 18:17:20 EST")

[commit-bot: I haz the power, 2015-11-06 15:13:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407063005/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407063005/90001

[commit-bot: I haz the power, 2015-11-06 15:27:26]

Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/aa4ba90792a99eed96ac51006bd478d453a751c4