Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1407053004: Add a comment to fast/forms/select/optgroup-clicking.html about a failure on OSX. (Closed)

Created:
5 years, 2 months ago by tkent
Modified:
5 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comment to fast/forms/select/optgroup-clicking.html about a failure on OSX. It's an expected behavior. BUG=234018 Committed: https://crrev.com/221ab82ebc9c347dedc6a5575616ea4066047191 Cr-Commit-Position: refs/heads/master@{#355718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/select/optgroup-clicking.html View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select/optgroup-clicking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/optgroup-clicking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
Keishi, please review this.
5 years, 2 months ago (2015-10-22 01:58:24 UTC) #2
keishi
LGTM
5 years, 2 months ago (2015-10-23 02:21:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407053004/1
5 years, 2 months ago (2015-10-23 02:32:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 03:06:47 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 03:07:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/221ab82ebc9c347dedc6a5575616ea4066047191
Cr-Commit-Position: refs/heads/master@{#355718}

Powered by Google App Engine
This is Rietveld 408576698