Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1407043009: Default off LTCG for human builds. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Default off LTCG for human builds. It's absurdly slow. We can turn it back on with skia> python gyp_skia -Dskia_win_ltcg=1 The bots will automatically define skia_is_bot and skia_win_ltcg. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f7c0822911e736940a8690fb0553821561bf8ac7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gyp/common_variables.gypi View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein
5 years, 1 month ago (2015-10-27 17:53:07 UTC) #6
bsalomon
lgtm
5 years, 1 month ago (2015-10-27 18:01:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407043009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407043009/1
5 years, 1 month ago (2015-10-27 18:13:40 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 18:24:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f7c0822911e736940a8690fb0553821561bf8ac7

Powered by Google App Engine
This is Rietveld 408576698