Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1407043004: [Crankshaft] Allow inlining of callees that don't pass FLAG_hydrogen_filter (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow
Modified:
5 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Crankshaft] Allow inlining of callees that don't pass FLAG_hydrogen_filter To be useful for narrowing down bugs, --hydrogen-filter shouldn't prevent any inlining that the function(s) being allowed to get optimized want(s) to do. Free bonus content in this CL: support FLAG_stop_at in lithium-codegen-arm64, copied from full-codegen-arm64. Committed: https://crrev.com/192c0f7234a492e3b92b7a2ef0fae7a917d104ce Cr-Commit-Position: refs/heads/master@{#31333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
Some fallout from a recent debugging session. PTAL.
5 years, 2 months ago (2015-10-16 11:18:35 UTC) #2
Yang
On 2015/10/16 11:18:35, Jakob wrote: > Some fallout from a recent debugging session. PTAL. lgtm.
5 years, 2 months ago (2015-10-16 11:21:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407043004/1
5 years, 2 months ago (2015-10-16 11:22:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 11:56:41 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 11:57:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/192c0f7234a492e3b92b7a2ef0fae7a917d104ce
Cr-Commit-Position: refs/heads/master@{#31333}

Powered by Google App Engine
This is Rietveld 408576698