Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1407043002: Added more constructors to CallbackLayerAnimationObserver. (Closed)

Created:
5 years, 2 months ago by bruthig
Modified:
5 years, 2 months ago
Reviewers:
ajuma
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added more constructors to CallbackLayerAnimationObserver. Some clients of the CallbackLayerAnimationObserver might not need require all callbacks to be notified. This CL adds some new constructors with default behavior for unspecified callbacks. TEST=CallbackLayerAnimationObserverDestructionTest.VerifyFalseAutoDelete TEST=CallbackLayerAnimationObserverDestructionTest.VerifyTrueAutoDelete Committed: https://crrev.com/a33cc7d19a2c878e2a7d9b4a540d06f3e0c3fc16 Cr-Commit-Position: refs/heads/master@{#354369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -24 lines) Patch
M ui/compositor/callback_layer_animation_observer.h View 3 chunks +42 lines, -7 lines 0 comments Download
M ui/compositor/callback_layer_animation_observer.cc View 1 chunk +26 lines, -9 lines 0 comments Download
M ui/compositor/callback_layer_animation_observer_unittest.cc View 4 chunks +73 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bruthig
ajuma@, can you PTAL?
5 years, 2 months ago (2015-10-15 20:11:06 UTC) #2
ajuma
On 2015/10/15 20:11:06, bruthig wrote: > ajuma@, can you PTAL? lgtm
5 years, 2 months ago (2015-10-15 20:42:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407043002/1
5 years, 2 months ago (2015-10-15 20:43:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 21:47:26 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 21:50:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a33cc7d19a2c878e2a7d9b4a540d06f3e0c3fc16
Cr-Commit-Position: refs/heads/master@{#354369}

Powered by Google App Engine
This is Rietveld 408576698