Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: tools/battor_agent/battor_agent.cc

Issue 1407033008: Makes the BattOrAgent asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added //base dependency to bin Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/battor_agent/battor_agent.h ('k') | tools/battor_agent/battor_agent_bin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/battor_agent/battor_agent.cc
diff --git a/tools/battor_agent/battor_agent.cc b/tools/battor_agent/battor_agent.cc
index 744c61b6db5ae1430260be1880ac18bcc6f0d3a5..73d2fc8e42f896cc4e34280a12542a7e28c3fbcc 100644
--- a/tools/battor_agent/battor_agent.cc
+++ b/tools/battor_agent/battor_agent.cc
@@ -6,30 +6,38 @@
#include <iostream>
+#include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
+
namespace battor {
BattOrAgent::BattOrAgent(const std::string& path) : path_(path) {
- // TODO: Open up a serial connection with the BattOr.
+ // TODO(charliea): Open up a serial connection with the BattOr.
}
BattOrAgent::~BattOrAgent() {
- // TODO: Close the serial connection with the BattOr.
+ // TODO(charliea): Close the serial connection with the BattOr.
}
void BattOrAgent::StartTracing() {
- // TODO: Tell the BattOr to start tracing.
+ // TODO(charliea): Tell the BattOr to start tracing.
}
-void BattOrAgent::StopTracing(std::string* out_trace) {
- // TODO: Tell the BattOr to stop tracing.
+void BattOrAgent::StopTracing(std::string* trace_output,
+ const base::Closure& callback) {
+ // TODO(charliea): Tell the BattOr to stop tracing.
+ *trace_output = "battor trace output";
+ callback.Run();
}
-void BattOrAgent::RecordClockSyncMarker(const std::string& marker) {
- // TODO: Tell the BattOr to record the specified clock sync marker.
+void BattOrAgent::RecordClockSyncMarker(const std::string& marker,
+ const base::Closure& callback) {
+ // TODO(charliea): Tell the BattOr to record the specified clock sync marker.
+ callback.Run();
}
void BattOrAgent::IssueClockSyncMarker() {
- // TODO: Tell atrace to issue a clock sync marker.
+ // TODO(charliea): Tell atrace to issue a clock sync marker.
}
} // namespace battor
« no previous file with comments | « tools/battor_agent/battor_agent.h ('k') | tools/battor_agent/battor_agent_bin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698