Presubmit enforce that DCHECK_IS_ON() does not forget the braces.

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
@@ skipping 356 matching lines @@
     for line_num, line in f.ChangedContents():
       if 'UNIT_TEST ' in line or line.endswith('UNIT_TEST'):
         problems.append('    %s:%d' % (f.LocalPath(), line_num))
 
   if not problems:
     return []
   return [output_api.PresubmitPromptWarning('UNIT_TEST is only for headers.\n' +
       '\n'.join(problems))]
 
 
+def _CheckDCHECK_IS_ONHasBraces(input_api, output_api):
+  """Checks to make sure DCHECK_IS_ON() does not skip the braces"""

[ncarter (slow), 2015/10/23 20:39:02]

Nit: period at end of sentence per
https://www.python.org/dev/peps/pep-0257/#id16 (via the python style guide).

[danakj, 2015/10/23 21:53:16]

Done and fixed what I copied from.

+  files = []
+  pattern = input_api.re.compile(r'DCHECK_IS_ON(?!\(\))',
+                                 input_api.re.MULTILINE)
+  for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
+    if (not f.LocalPath().endswith(('.cc', '.mm', '.h'))):
+      continue
+    contents = input_api.ReadFile(f)

[ncarter (slow), 2015/10/23 20:39:02]

Should this iterate over ChangedContents (the diff lines) instead of the whole
file?

[danakj, 2015/10/23 21:53:16]

Ya good point, copied from the UNIT_TEST one. Fixed.

+    if pattern.search(contents):
+      files.append(f)
+
+  if not files:
+    return []
+  return [ output_api.PresubmitError(
+      'Use of DCHECK_IS_ON() must be written as "#if DCHECK_IS_ON()", not '
+      'forgetting the braces.',
+      files) ]
+
+
 def _FindHistogramNameInLine(histogram_name, line):
   """Tries to find a histogram name or prefix in a line."""
   if not "affected-histogram" in line:
     return histogram_name in line
   # A histogram_suffixes tag type has an affected-histogram name as a prefix of
   # the histogram_name.
   if not '"' in line:
     return False
   histogram_prefix = line.split('\"')[1]
   return histogram_prefix in histogram_name
@@ skipping 1246 matching lines @@
   """Checks common to both upload and commit."""
   results = []
   results.extend(input_api.canned_checks.PanProjectChecks(
       input_api, output_api,
       excluded_paths=_EXCLUDED_PATHS + _TESTRUNNER_PATHS))
   results.extend(_CheckAuthorizedAuthor(input_api, output_api))
   results.extend(
       _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
   results.extend(_CheckNoIOStreamInHeaders(input_api, output_api))
   results.extend(_CheckNoUNIT_TESTInSourceFiles(input_api, output_api))
+  results.extend(_CheckDCHECK_IS_ONHasBraces(input_api, output_api))
   results.extend(_CheckNoNewWStrings(input_api, output_api))
   results.extend(_CheckNoDEPSGIT(input_api, output_api))
   results.extend(_CheckNoBannedFunctions(input_api, output_api))
   results.extend(_CheckNoPragmaOnce(input_api, output_api))
   results.extend(_CheckNoTrinaryTrueFalse(input_api, output_api))
   results.extend(_CheckUnwantedDependencies(input_api, output_api))
   results.extend(_CheckFilePermissions(input_api, output_api))
   results.extend(_CheckNoAuraWindowPropertyHInHeaders(input_api, output_api))
   results.extend(_CheckIncludeOrder(input_api, output_api))
   results.extend(_CheckForVersionControlConflicts(input_api, output_api))
@@ skipping 326 matching lines @@
   for master in masters:
     try_config.setdefault(master, {})
     for builder in masters[master]:
       # Do not trigger presubmit builders, since they're likely to fail
       # (e.g. OWNERS checks before finished code review), and we're
       # running local presubmit anyway.
       if 'presubmit' not in builder:
         try_config[master][builder] = ['defaulttests']
 
   return try_config