Issue 140703002: Merged r18483, r18484 into 3.23 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140703002: Merged r18483, r18484 into 3.23 branch. (Closed)

Created:
6 years, 11 months ago by ulan

Modified:
6 years, 11 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.23

Visibility:
Public.

Merged r18483, r18484 into 3.23 branch. Fix selection of popular pages in store buffer. Correctly handle instances without elements in polymorphic keyed load/store. BUG=331444, 331416 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18637

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -28 lines)			Patch
M	src/store-buffer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-331416.js	View	2 chunks	+21 lines, -17 lines	0 comments	Download
A +	test/mjsunit/regress/regress-331444.js	View	2 chunks	+11 lines, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

ulan

PTAL, this merges https://code.google.com/p/v8/source/detail?r=18483 https://code.google.com/p/v8/source/detail?r=18484 Patches applied cleanly.

6 years, 11 months ago (2014-01-16 09:23:21 UTC) #2

ulan

6 years, 11 months ago (2014-01-16 09:42:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r18637 (presubmit successful).