Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1407003015: [turbofan] Fix for register allocation crash (Closed)

Created:
5 years, 2 months ago by Mircea Trofin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix for register allocation crash It appears we haven't wired in the 32 float constant passed on the stack. BUG=v8:4506 LOG=n Committed: https://crrev.com/f20c8427aa07712628fada6f8e4bb04886e1d0f2 Cr-Commit-Position: refs/heads/master@{#31453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
5 years, 2 months ago (2015-10-22 07:02:06 UTC) #4
Benedikt Meurer
LGTM, thanks.
5 years, 2 months ago (2015-10-22 07:03:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003015/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003015/1
5 years, 2 months ago (2015-10-22 07:03:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 07:22:48 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 07:22:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f20c8427aa07712628fada6f8e4bb04886e1d0f2
Cr-Commit-Position: refs/heads/master@{#31453}

Powered by Google App Engine
This is Rietveld 408576698