Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407003005: Lists: Render marker text closer to list items. (Closed)

Created:
5 years, 2 months ago by wkorman
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lists: Render marker text closer to list items. More closely matches rendering behavior of other browsers. BUG=472084 Committed: https://crrev.com/ae74f84464416b7d9fc63e808c4161eb08ffc1c3 Cr-Commit-Position: refs/heads/master@{#354660}

Patch Set 1 #

Patch Set 2 : Add test expectations. #

Patch Set 3 : Update expectations, de-reference new tests due to font layout variance. #

Patch Set 4 : Update expectations. #

Patch Set 5 : Update test expectations, again. #

Patch Set 6 : Updated test expectations, again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/lists/list-marker-padding-overflow-hidden.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/lists/list-marker-padding-overflow-hidden-rtl.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 5 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
wkorman
5 years, 2 months ago (2015-10-16 05:14:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003005/20001
5 years, 2 months ago (2015-10-16 05:14:43 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/127254)
5 years, 2 months ago (2015-10-16 06:37:57 UTC) #6
eae
LGTM
5 years, 2 months ago (2015-10-16 16:25:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003005/40001
5 years, 2 months ago (2015-10-16 17:17:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/127440)
5 years, 2 months ago (2015-10-16 18:12:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003005/60001
5 years, 2 months ago (2015-10-16 18:21:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/121883)
5 years, 2 months ago (2015-10-16 21:54:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003005/100001
5 years, 2 months ago (2015-10-17 00:55:58 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-17 01:56:11 UTC) #21
commit-bot: I haz the power
5 years, 2 months ago (2015-10-17 01:57:05 UTC) #22
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/ae74f84464416b7d9fc63e808c4161eb08ffc1c3
Cr-Commit-Position: refs/heads/master@{#354660}

Powered by Google App Engine
This is Rietveld 408576698