Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: utils/pub/validator/name.dart

Issue 14070010: Refactor Future constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added co19 issue number. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/validator/license.dart ('k') | utils/pub/validator/pubspec_field.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library name_validator; 5 library name_validator;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:io'; 8 import 'dart:io';
9 9
10 import 'package:pathos/path.dart' as path; 10 import 'package:pathos/path.dart' as path;
(...skipping 10 matching lines...) Expand all
21 "new", "null", "return", "super", "switch", "this", "throw", "true", "try", 21 "new", "null", "return", "super", "switch", "this", "throw", "true", "try",
22 "var", "void", "while", "with" 22 "var", "void", "while", "with"
23 ]; 23 ];
24 24
25 /// A validator that validates the name of the package and its libraries. 25 /// A validator that validates the name of the package and its libraries.
26 class NameValidator extends Validator { 26 class NameValidator extends Validator {
27 NameValidator(Entrypoint entrypoint) 27 NameValidator(Entrypoint entrypoint)
28 : super(entrypoint); 28 : super(entrypoint);
29 29
30 Future validate() { 30 Future validate() {
31 return new Future.of(() { 31 return new Future.sync(() {
32 _checkName(entrypoint.root.name, 'Package name "${entrypoint.root.name}"', 32 _checkName(entrypoint.root.name, 'Package name "${entrypoint.root.name}"',
33 isPackage: true); 33 isPackage: true);
34 34
35 var libraries = _libraries; 35 var libraries = _libraries;
36 for (var library in libraries) { 36 for (var library in libraries) {
37 var libName = path.basenameWithoutExtension(library); 37 var libName = path.basenameWithoutExtension(library);
38 _checkName(libName, 'The name of "$library", "$libName",', 38 _checkName(libName, 'The name of "$library", "$libName",',
39 isPackage: false); 39 isPackage: false);
40 } 40 }
41 41
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 builder 90 builder
91 ..write(source.substring(lastMatchEnd, match.start + 1)) 91 ..write(source.substring(lastMatchEnd, match.start + 1))
92 ..write("_") 92 ..write("_")
93 ..write(match.group(1).toLowerCase()); 93 ..write(match.group(1).toLowerCase());
94 lastMatchEnd = match.end; 94 lastMatchEnd = match.end;
95 } 95 }
96 builder.write(source.substring(lastMatchEnd)); 96 builder.write(source.substring(lastMatchEnd));
97 return builder.toString().toLowerCase(); 97 return builder.toString().toLowerCase();
98 } 98 }
99 } 99 }
OLDNEW
« no previous file with comments | « utils/pub/validator/license.dart ('k') | utils/pub/validator/pubspec_field.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698