Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1406993003: aura: Handle released widget when GPU channel gets established (Closed)

Created:
5 years, 2 months ago by no sievers
Modified:
5 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura: Handle released widget when GPU channel gets established Allow this sequence: GpuProcessTransporFactory::CreateOutputSurface() EstablishGpuChannel() Compositor::ReleaseAcceleratedWidget() GpuProcessTransportFactory::EstablishedGpuChannel() BUG=513540 Committed: https://crrev.com/aa1dc3494905b81e33c1c7df2f09fdc492589d79 Cr-Commit-Position: refs/heads/master@{#355121}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
no sievers
I think I missed this corner case. Is that ok to remove the DCHECK() here ...
5 years, 2 months ago (2015-10-16 20:18:21 UTC) #2
piman
https://codereview.chromium.org/1406993003/diff/1/content/browser/compositor/gpu_process_transport_factory.cc File content/browser/compositor/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/1406993003/diff/1/content/browser/compositor/gpu_process_transport_factory.cc#newcode233 content/browser/compositor/gpu_process_transport_factory.cc:233: PerCompositorData* data = per_compositor_data_[compositor.get()]; Can you use per_compositor_data_.find(compositor.get()), so ...
5 years, 2 months ago (2015-10-20 01:51:49 UTC) #3
no sievers
On 2015/10/20 01:51:49, piman (slow to review) wrote: > https://codereview.chromium.org/1406993003/diff/1/content/browser/compositor/gpu_process_transport_factory.cc > File content/browser/compositor/gpu_process_transport_factory.cc (right): > ...
5 years, 2 months ago (2015-10-20 17:16:14 UTC) #5
piman
lgtm
5 years, 2 months ago (2015-10-20 17:43:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406993003/40001
5 years, 2 months ago (2015-10-20 18:04:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 2 months ago (2015-10-20 18:55:52 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 18:56:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa1dc3494905b81e33c1c7df2f09fdc492589d79
Cr-Commit-Position: refs/heads/master@{#355121}

Powered by Google App Engine
This is Rietveld 408576698