Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1406983009: Roll buildtools ef7f1f539c..acafdaa4e8 (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools ef7f1f539c..acafdaa4e8 In order to roll GN adf2cc6066..e35662dd4e (r354085:r356963) and pick up the following changes: 784ffb6 Fix GN unittests on windows broken by abs-path change 987f4a5 [GN] Allow spaces in output names and other substitutions. 5b6813c Make sure abs-path gn labels have separate target_gen_dirs 1c010e5 Make GN --as=output relative to the root build directory. a2d721a Handle Mozilla license blocks in the GN header checker. TBR=brettw@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Committed: https://crrev.com/0d34fd4ba8f68151f4cc38b61c2a1dd63c3e281f Cr-Commit-Position: refs/heads/master@{#357022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
5 years, 1 month ago (2015-10-29 22:49:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406983009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406983009/1
5 years, 1 month ago (2015-10-29 22:50:35 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_gn_x64_rel on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-10-30 00:54:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406983009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406983009/1
5 years, 1 month ago (2015-10-30 01:29:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 02:15:11 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 02:16:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d34fd4ba8f68151f4cc38b61c2a1dd63c3e281f
Cr-Commit-Position: refs/heads/master@{#357022}

Powered by Google App Engine
This is Rietveld 408576698