Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1406983008: [iOS] ios/web no longer depends on content::BrowserThread. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] ios/web no longer depends on content::BrowserThread. Remove the shim implementation of web::WebThread based on content::BrowserThread now that Chrome on iOS uses ios/web for the startup. Add call to WebThreadImpl::FlushThreadPoolHelperForTesting() to WebTestSuite to mirror ContentTestSuite. BUG=547725 Committed: https://crrev.com/d646dbcd24bb3219407803357c9239938232a8fc Cr-Commit-Position: refs/heads/master@{#357330}

Patch Set 1 #

Patch Set 2 : Fix components/components_tests.gyp #

Patch Set 3 : Synchronise with downstream code #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -467 lines) Patch
M components/components_tests.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/app/web_main_loop.mm View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M ios/web/ios_web.gyp View 1 2 7 chunks +6 lines, -80 lines 0 comments Download
M ios/web/ios_web_shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/ios_web_unittests.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/test_web_thread_bundle.h View 2 chunks +14 lines, -2 lines 0 comments Download
M ios/web/public/web_thread.h View 2 chunks +12 lines, -0 lines 0 comments Download
D ios/web/test/test_web_thread_adapter.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M ios/web/test/test_web_thread_bundle.cc View 3 chunks +4 lines, -43 lines 0 comments Download
D ios/web/test/test_web_thread_bundle_adapter.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M ios/web/test/web_test_suite.cc View 2 chunks +17 lines, -0 lines 0 comments Download
D ios/web/web_thread_adapter.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ios/web/web_thread_adapter.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M ios/web/web_thread_impl.h View 3 chunks +2 lines, -15 lines 0 comments Download
M ios/web/web_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sdefresne
Please take a look. stuartmorgan: FYI
5 years, 1 month ago (2015-10-27 17:52:01 UTC) #2
droger
lgtm
5 years, 1 month ago (2015-10-27 18:03:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406983008/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406983008/80001
5 years, 1 month ago (2015-11-02 10:32:55 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 1 month ago (2015-11-02 10:59:32 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 11:00:37 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d646dbcd24bb3219407803357c9239938232a8fc
Cr-Commit-Position: refs/heads/master@{#357330}

Powered by Google App Engine
This is Rietveld 408576698