Issue 1406983007: Compute and display tasks input timings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406983007: Compute and display tasks input timings. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Compute and display tasks input timings. It's not perfectly useful - it computes just cumulative timings. So, it includes not just time for extracting and gathering inputs, but also actual time to compute them. But it is still useful to compare between runs after changes to tasks inputs, because computing time should be the same, so the difference is this extracting/gathering time. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/07acac8b8e87d66e5e89fb7a94596428c98ca212

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -4 lines)			Patch
	M	pkg/analysis_server/lib/src/status/get_handler.dart	View		2 chunks	+43 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/lib/src/task/driver.dart	View		7 chunks	+37 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1406983007/diff/1/pkg/analyzer/lib/src/task/driver.dart File pkg/analyzer/lib/src/task/driver.dart (right): https://codereview.chromium.org/1406983007/diff/1/pkg/analyzer/lib/src/task/driver.dart#newcode618 pkg/analyzer/lib/src/task/driver.dart:618: stopwatch = stopwatchMap[descriptor.name]; The descriptors are long-lived and ...

5 years, 2 months ago (2015-10-23 16:27:11 UTC) #2

scheglov

5 years, 2 months ago (2015-10-23 16:38:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
07acac8b8e87d66e5e89fb7a94596428c98ca212 (presubmit successful).

Expand Messages | Collapse Messages