Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1406983004: [Turbofan] Re-enable single splinter. (Closed)

Created:
5 years, 2 months ago by Mircea Trofin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Re-enable single splinter. Revert "Revert of [turbofan] Splinter into one range. (patchset #2 id:80001 of https://codereview.chromium.org/1391023007/ )" This reverts commit 23a8837fcc8a212a4a2608a9bf53f908a7a91728. Also added a CHECK in Merge to validate that splitting yields a different range and thus advances the algorithm. Ran stress bots successfully. Likely my earlier change in Splintering addressed the stress test scenario that was looping infinitely. BUG= Committed: https://crrev.com/3e2e2062e783dd76dac21313013585da5a4605be Cr-Commit-Position: refs/heads/master@{#31430}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -63 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/live-range-separator.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/compiler/register-allocator.h View 4 chunks +15 lines, -4 lines 0 comments Download
M src/compiler/register-allocator.cc View 5 chunks +80 lines, -48 lines 0 comments Download
M test/unittests/compiler/live-range-unittest.cc View 3 chunks +28 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
Please try with re-enabling the single Merge exit in JSNativeContextSpecialization.
5 years, 2 months ago (2015-10-21 03:50:58 UTC) #4
Mircea Trofin
On 2015/10/21 03:50:58, Benedikt Meurer wrote: > Please try with re-enabling the single Merge exit ...
5 years, 2 months ago (2015-10-21 04:46:05 UTC) #5
Benedikt Meurer
LGTM.
5 years, 2 months ago (2015-10-21 08:07:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406983004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406983004/20001
5 years, 2 months ago (2015-10-21 08:08:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-21 08:09:36 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 08:09:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e2e2062e783dd76dac21313013585da5a4605be
Cr-Commit-Position: refs/heads/master@{#31430}

Powered by Google App Engine
This is Rietveld 408576698