Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1406983003: Remove the checker and corresponding dead code (Closed)

Created:
5 years, 2 months ago by vsm
Modified:
5 years, 2 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the checker and corresponding dead code This is all logic now in the analyzer. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0cb5e46fba703fa904699e2378216c85f8e3e53b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4784 lines) Patch
M bin/edit_files.dart View 2 chunks +1 line, -3 lines 0 comments Download
M lib/devc.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/analysis_context.dart View 2 chunks +5 lines, -15 lines 0 comments Download
D lib/src/checker/checker.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D lib/src/checker/resolver.dart View 1 chunk +0 lines, -757 lines 0 comments Download
D lib/src/checker/rules.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M lib/src/codegen/code_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/js_codegen.dart View 2 chunks +1 line, -1 line 0 comments Download
M lib/src/codegen/reify_coercions.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/compiler.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/options.dart View 6 chunks +3 lines, -8 lines 0 comments Download
M lib/src/server/server.dart View 1 chunk +1 line, -2 lines 0 comments Download
D lib/strong_mode.dart View 1 chunk +0 lines, -112 lines 0 comments Download
M test/all_tests.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D test/checker/checker_test.dart View 1 chunk +0 lines, -2319 lines 0 comments Download
D test/checker/dart_foobar.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D test/checker/inferred_type_test.dart View 1 chunk +0 lines, -1291 lines 0 comments Download
D test/checker/self_host_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M test/codegen_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M test/dependency_graph_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M test/end_to_end_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/report_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M test/testing.dart View 3 chunks +9 lines, -212 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
5 years, 2 months ago (2015-10-19 21:12:48 UTC) #3
Jennifer Messerly
lgtm
5 years, 2 months ago (2015-10-19 21:37:38 UTC) #4
vsm
5 years, 2 months ago (2015-10-19 21:38:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0cb5e46fba703fa904699e2378216c85f8e3e53b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698