third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h - Issue 1406973008: Calculate minimum column height after layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 1406973008: Calculate minimum column height after layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp ('k') | third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

index a78072e3516703ce7ab5a2dbe8b1b68062603ae0..54116a34840e31d36098cac6273fc5e20563c03d 100644

--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

@@ -61,7 +61,6 @@ public:

bool heightIsAuto() const;

void resetColumnHeight();

- void updateMinimumColumnHeight(LayoutUnit height) { m_minimumColumnHeight = std::max(height, m_minimumColumnHeight); }

bool recalculateColumnHeight(BalancedColumnHeightCalculation calculationMode);

LayoutSize flowThreadTranslationAtOffset(LayoutUnit offsetInFlowThread) const;

@@ -113,9 +112,7 @@ private:

LayoutUnit m_columnHeight;

- // The following variables are used when balancing the column set.

LayoutUnit m_maxColumnHeight; // Maximum column height allowed.

- LayoutUnit m_minimumColumnHeight;

};

// List of all fragmentainer groups within a column set. There will always be at least one