Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

Issue 1406973008: Calculate minimum column height after layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
diff --git a/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp b/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
index 65d3f4cb8a107682d467ffffa3ec44b395e26cc3..989f2d8d0d04ee35211470212a40d4bf7c8780ec 100644
--- a/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
+++ b/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
@@ -92,7 +92,8 @@ LayoutUnit InitialColumnHeightFinder::initialMinimalBalancedHeight() const
{
unsigned index = contentRunIndexWithTallestColumns();
LayoutUnit startOffset = index > 0 ? m_contentRuns[index - 1].breakOffset() : group().logicalTopInFlowThread();
- return m_contentRuns[index].columnLogicalHeight(startOffset);
+ LayoutUnit logicalHeightEstimate = m_contentRuns[index].columnLogicalHeight(startOffset);
+ return std::max(logicalHeightEstimate, m_minimumColumnLogicalHeight);
}
void InitialColumnHeightFinder::examineBoxAfterEntering(const LayoutBox& box)
@@ -107,16 +108,38 @@ void InitialColumnHeightFinder::examineBoxAfterEntering(const LayoutBox& box)
if (box.hasForcedBreakAfter())
addContentRun(flowThreadOffset() + box.logicalHeight());
+
+ if (box.paginationBreakability() != LayoutBox::AllowAnyBreaks) {
+ LayoutUnit unsplittableLogicalHeight = box.logicalHeight();
+ if (box.isFloating())
+ unsplittableLogicalHeight += box.marginBefore() + box.marginAfter();
+ if (m_minimumColumnLogicalHeight < unsplittableLogicalHeight)
+ m_minimumColumnLogicalHeight = unsplittableLogicalHeight;
+ }
}
void InitialColumnHeightFinder::examineBoxBeforeLeaving(const LayoutBox& box)
{
}
+static inline LayoutUnit columnLogicalHeightRequirementForLine(const ComputedStyle& style, const RootInlineBox& lastLine)
+{
+ // We may require a certain minimum number of lines per page in order to satisfy
+ // orphans and widows, and that may affect the minimum page height.
+ unsigned minimumLineCount = std::max<unsigned>(style.hasAutoOrphans() ? 1 : style.orphans(), style.widows());
+ const RootInlineBox* firstLine = &lastLine;
+ for (unsigned i = 1; i < minimumLineCount && firstLine->prevRootBox(); i++)
+ firstLine = firstLine->prevRootBox();
+ return lastLine.lineBottomWithLeading() - firstLine->lineTopWithLeading();
+}
+
void InitialColumnHeightFinder::examineLine(const RootInlineBox& line)
{
LayoutUnit lineTop = line.lineTopWithLeading();
LayoutUnit lineTopInFlowThread = flowThreadOffset() + lineTop;
+ LayoutUnit minimumLogialHeight = columnLogicalHeightRequirementForLine(line.block().styleRef(), line);
+ if (m_minimumColumnLogicalHeight < minimumLogialHeight)
+ m_minimumColumnLogicalHeight = minimumLogialHeight;
ASSERT(isFirstAfterBreak(lineTopInFlowThread) || !line.paginationStrut());
if (isFirstAfterBreak(lineTopInFlowThread))
recordStrutBeforeOffset(lineTopInFlowThread, line.paginationStrut());
« no previous file with comments | « third_party/WebKit/Source/core/layout/ColumnBalancer.h ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698