Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1406973008: Calculate minimum column height after layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 void addColumnSetToThread(LayoutMultiColumnSet*) override; 220 void addColumnSetToThread(LayoutMultiColumnSet*) override;
221 void willBeRemovedFromTree() override; 221 void willBeRemovedFromTree() override;
222 void flowThreadDescendantWasInserted(LayoutObject*) final; 222 void flowThreadDescendantWasInserted(LayoutObject*) final;
223 void flowThreadDescendantWillBeRemoved(LayoutObject*) final; 223 void flowThreadDescendantWillBeRemoved(LayoutObject*) final;
224 void flowThreadDescendantStyleWillChange(LayoutBox*, StyleDifference, const ComputedStyle& newStyle) override; 224 void flowThreadDescendantStyleWillChange(LayoutBox*, StyleDifference, const ComputedStyle& newStyle) override;
225 void flowThreadDescendantStyleDidChange(LayoutBox*, StyleDifference, const C omputedStyle& oldStyle) override; 225 void flowThreadDescendantStyleDidChange(LayoutBox*, StyleDifference, const C omputedStyle& oldStyle) override;
226 void computePreferredLogicalWidths() override; 226 void computePreferredLogicalWidths() override;
227 void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, L ogicalExtentComputedValues&) const override; 227 void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, L ogicalExtentComputedValues&) const override;
228 void updateLogicalWidth() override; 228 void updateLogicalWidth() override;
229 void contentWasLaidOut(LayoutUnit logicalTopInFlowThreadAfterPagination) ove rride; 229 void contentWasLaidOut(LayoutUnit logicalTopInFlowThreadAfterPagination) ove rride;
230 void updateMinimumPageHeight(LayoutUnit offset, LayoutUnit minHeight) overri de;
231 230
232 // The last set we worked on. It's not to be used as the "current set". The concept of a 231 // The last set we worked on. It's not to be used as the "current set". The concept of a
233 // "current set" is difficult, since layout may jump back and forth in the t ree, due to wrong 232 // "current set" is difficult, since layout may jump back and forth in the t ree, due to wrong
234 // top location estimates (due to e.g. margin collapsing), and possibly for other reasons. 233 // top location estimates (due to e.g. margin collapsing), and possibly for other reasons.
235 LayoutMultiColumnSet* m_lastSetWorkedOn; 234 LayoutMultiColumnSet* m_lastSetWorkedOn;
236 235
237 unsigned m_columnCount; // The used value of column-count 236 unsigned m_columnCount; // The used value of column-count
238 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto. 237 LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto.
239 238
240 // Cached block offset from this flow thread to the enclosing flow thread, i f any. In the 239 // Cached block offset from this flow thread to the enclosing flow thread, i f any. In the
241 // coordinate space of the enclosing flow thread. 240 // coordinate space of the enclosing flow thread.
242 LayoutUnit m_blockOffsetInEnclosingFlowThread; 241 LayoutUnit m_blockOffsetInEnclosingFlowThread;
243 242
244 bool m_inBalancingPass; // Set when relayouting for column balancing. 243 bool m_inBalancingPass; // Set when relayouting for column balancing.
245 bool m_needsColumnHeightsRecalculation; // Set when we need to recalculate t he column set heights after layout. 244 bool m_needsColumnHeightsRecalculation; // Set when we need to recalculate t he column set heights after layout.
246 bool m_progressionIsInline; // Always true for regular multicol. False for p aged-y overflow. 245 bool m_progressionIsInline; // Always true for regular multicol. False for p aged-y overflow.
247 bool m_isBeingEvacuated; 246 bool m_isBeingEvacuated;
248 }; 247 };
249 248
250 // Cannot use DEFINE_LAYOUT_OBJECT_TYPE_CASTS here, because isMultiColumnFlowThr ead() is defined in 249 // Cannot use DEFINE_LAYOUT_OBJECT_TYPE_CASTS here, because isMultiColumnFlowThr ead() is defined in
251 // LayoutFlowThread, not in LayoutObject. 250 // LayoutFlowThread, not in LayoutObject.
252 DEFINE_TYPE_CASTS(LayoutMultiColumnFlowThread, LayoutFlowThread, object, object- >isLayoutMultiColumnFlowThread(), object.isLayoutMultiColumnFlowThread()); 251 DEFINE_TYPE_CASTS(LayoutMultiColumnFlowThread, LayoutFlowThread, object, object- >isLayoutMultiColumnFlowThread(), object.isLayoutMultiColumnFlowThread());
253 252
254 } // namespace blink 253 } // namespace blink
255 254
256 #endif // LayoutMultiColumnFlowThread_h 255 #endif // LayoutMultiColumnFlowThread_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698