Make retries in content (and above) test launcher really serial

Make retries in content (and above) test launcher really serial

BUG=none

Committed: https://crrev.com/fe32d674e1a7f83a9e672b2384d9f36666057da1
Cr-Commit-Position: refs/heads/master@{#357140}

[Paweł Hajdan Jr., 2015-10-29 12:50:07]

phajdan.jr@chromium.org changed reviewers:
+ sky@chromium.org

[Paweł Hajdan Jr., 2015-10-29 14:39:52]

Description was changed from

==========
Make retries in content (and above) test launcher really serial

BUG=545006
==========

to

==========
Make retries in content (and above) test launcher really serial

BUG=none
==========

[sky, 2015-10-29 17:20:34]

https://codereview.chromium.org/1406973006/diff/1/content/public/test/test_la...
File content/public/test/test_launcher.cc (right):

https://codereview.chromium.org/1406973006/diff/1/content/public/test/test_la...
content/public/test/test_launcher.cc:333: std::string
test_name(test_names.back());
Shouldn't you run test_names.front() first?

https://codereview.chromium.org/1406973006/diff/1/content/public/test/test_la...
content/public/test/test_launcher.cc:334: std::vector<std::string>
test_names_copy(test_names);
nit: std::vector<std::string> test_names_copy(test_names.begin(),
test_names.end() - 1) and nuke the next line.

[Paweł Hajdan Jr., 2015-10-30 14:38:45]

PTAL

https://codereview.chromium.org/1406973006/diff/1/content/public/test/test_la...
File content/public/test/test_launcher.cc (right):

https://codereview.chromium.org/1406973006/diff/1/content/public/test/test_la...
content/public/test/test_launcher.cc:333: std::string
test_name(test_names.back());
On 2015/10/29 at 17:20:34, sky wrote:
> Shouldn't you run test_names.front() first?

Done.

https://codereview.chromium.org/1406973006/diff/1/content/public/test/test_la...
content/public/test/test_launcher.cc:334: std::vector<std::string>
test_names_copy(test_names);
On 2015/10/29 at 17:20:34, sky wrote:
> nit: std::vector<std::string> test_names_copy(test_names.begin(),
test_names.end() - 1) and nuke the next line.

Done.

[sky, 2015-10-30 16:57:53]

LGTM

[Paweł Hajdan Jr., 2015-10-30 17:35:58]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2015-10-30 17:36:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406973006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406973006/20001

[commit-bot: I haz the power, 2015-10-30 18:37:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-30 18:38:19]

Patchset 2 (id:??) landed as
https://crrev.com/fe32d674e1a7f83a9e672b2384d9f36666057da1
Cr-Commit-Position: refs/heads/master@{#357140}