third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1406953003: Compute positioned elements width correctly when it has anonymous ancestors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1406953003: Compute positioned elements width correctly when it has anonymous ancestors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/positioning/positioned-child-inside-relative-positioned-anonymous-block-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 4319671d0ac7e4a7120fca3ef59d05e0d5e5f3df..78cd0d7b2b193b1f671509af4405168dbec7d1ff 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2852,7 +2852,11 @@ LayoutUnit LayoutBox::containingBlockLogicalWidthForPositioned(const LayoutBoxMo

if (hasOverrideContainingBlockLogicalWidth())

return overrideContainingBlockContentLogicalWidth();

- if (containingBlock->isBox())

+ // Ensure we compute our width based on the width of our rel-pos inline container rather than any anonymous block

+ // created to manage a block-flow ancestor of ours in the rel-pos inline's inline flow.

+ if (containingBlock->isAnonymousBlock() && containingBlock->isRelPositioned())

+ containingBlock = toLayoutBox(containingBlock)->continuation();

+ else if (containingBlock->isBox())

return std::max(LayoutUnit(), toLayoutBox(containingBlock)->clientLogicalWidth());

ASSERT(containingBlock->isLayoutInline() && containingBlock->isInFlowPositioned());