Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1406943006: Pass type argument to Field construction, thus freezing that field, denoting it cannot be changed l… (Closed)

Created:
5 years, 1 month ago by srdjan
Modified:
5 years, 1 month ago
Reviewers:
regis, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass type argument to Field construction, thus freezing that field, denoting it cannot be changed later. BUG= R=regis@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c4aee382244609eb28c154aec9c702f6c709385a

Patch Set 1 #

Patch Set 2 : t #

Patch Set 3 : c #

Total comments: 2

Patch Set 4 : f #

Patch Set 5 : f #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -18 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 3 8 chunks +14 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 10 chunks +16 lines, -8 lines 0 comments Download
M runtime/vm/object_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
srdjan
5 years, 1 month ago (2015-11-09 20:21:50 UTC) #2
regis
lgtm https://codereview.chromium.org/1406943006/diff/40001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/1406943006/diff/40001/runtime/vm/object.h#newcode2973 runtime/vm/object.h:2973: // be boxed Missing period
5 years, 1 month ago (2015-11-09 20:28:15 UTC) #3
srdjan
https://codereview.chromium.org/1406943006/diff/40001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/1406943006/diff/40001/runtime/vm/object.h#newcode2973 runtime/vm/object.h:2973: // be boxed On 2015/11/09 20:28:15, regis wrote: > ...
5 years, 1 month ago (2015-11-09 21:09:40 UTC) #4
rmacnak
lgtm
5 years, 1 month ago (2015-11-09 21:13:26 UTC) #5
srdjan
5 years, 1 month ago (2015-11-09 21:55:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
c4aee382244609eb28c154aec9c702f6c709385a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698