Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1406943004: [sync] Isolate FOREIGN_SESSION_UPDATED notification in ProfileSyncService (Closed)

Created:
5 years, 1 month ago by blundell
Modified:
5 years, 1 month ago
Reviewers:
Ted C, Nicolas Zea, Dan Beam
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] Isolate FOREIGN_SESSION_UPDATED notification in ProfileSyncService This CL paves the way for elimination of the FOREIGN_SESSION_UPDATED notification as part of componentizing sync code. Concretely, it replaces the notification via a SyncServiceObserver method and changes consumers to use the observer method instead. Currently, ProfileSyncService triggers the observer callback by itself listening for the FOREIGN_SESSION_UPDATED method. Once SessionsSyncManager has been changed to communicate directly with ProfileSyncService rather than sending the notification, the notification can be eliminated entirely. BUG=512825 Committed: https://crrev.com/fc39f9aad7e4353304c7e2ad47f768871cd2bb83 Cr-Commit-Position: refs/heads/master@{#357061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -53 lines) Patch
M chrome/browser/android/foreign_session_helper.h View 4 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/android/foreign_session_helper.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 4 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.h View 4 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.cc View 4 chunks +3 lines, -18 lines 0 comments Download
M components/sync_driver/sync_service_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
blundell
zea: whole CL. dbeam: //chrome/browser/ui/webui tedchoc: //chrome/browser/android Nicolas, I figure that this should set things ...
5 years, 1 month ago (2015-10-29 14:37:52 UTC) #2
Ted C
On 2015/10/29 14:37:52, blundell wrote: > zea: whole CL. > dbeam: //chrome/browser/ui/webui > tedchoc: //chrome/browser/android ...
5 years, 1 month ago (2015-10-29 16:00:33 UTC) #3
Dan Beam
lgtm
5 years, 1 month ago (2015-10-29 20:38:17 UTC) #4
Nicolas Zea
lgtm
5 years, 1 month ago (2015-10-29 23:04:49 UTC) #5
Nicolas Zea
LGTM. FYI I'll be removing this notification dependency once I rebase 1408353005 onto this patch.
5 years, 1 month ago (2015-10-29 23:06:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406943004/1
5 years, 1 month ago (2015-10-30 06:58:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 08:26:07 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 08:27:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc39f9aad7e4353304c7e2ad47f768871cd2bb83
Cr-Commit-Position: refs/heads/master@{#357061}

Powered by Google App Engine
This is Rietveld 408576698