Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140693016: IDL compiler: interface and integer types for special operations (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: interface and integer types for special operations Misc. type handling. BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166290

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -120 lines) Patch
M Source/bindings/scripts/unstable/v8_interface.py View 1 2 5 chunks +12 lines, -6 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestSpecialOperationsIdentifierRaisesException.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A Source/bindings/tests/idls/TestSpecialOperationsInt.idl View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 5 chunks +13 lines, -10 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsInt.h View 1 chunk +29 lines, -30 lines 0 comments Download
A + Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 11 chunks +41 lines, -70 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-01-30 09:34:39 UTC) #1
haraken
LGTM https://codereview.chromium.org/140693016/diff/1/Source/bindings/scripts/unstable/v8_interface.py File Source/bindings/scripts/unstable/v8_interface.py (right): https://codereview.chromium.org/140693016/diff/1/Source/bindings/scripts/unstable/v8_interface.py#newcode527 Source/bindings/scripts/unstable/v8_interface.py:527: v8_types.is_integer_type(idl_type), Let me confirm: Did we decide that ...
6 years, 10 months ago (2014-01-30 10:55:24 UTC) #2
Nils Barth (inactive)
https://codereview.chromium.org/140693016/diff/1/Source/bindings/scripts/unstable/v8_interface.py File Source/bindings/scripts/unstable/v8_interface.py (right): https://codereview.chromium.org/140693016/diff/1/Source/bindings/scripts/unstable/v8_interface.py#newcode527 Source/bindings/scripts/unstable/v8_interface.py:527: v8_types.is_integer_type(idl_type), On 2014/01/30 10:55:25, haraken wrote: > Let me ...
6 years, 10 months ago (2014-01-30 11:00:50 UTC) #3
haraken
On 2014/01/30 11:00:50, Nils Barth wrote: > https://codereview.chromium.org/140693016/diff/1/Source/bindings/scripts/unstable/v8_interface.py > File Source/bindings/scripts/unstable/v8_interface.py (right): > > https://codereview.chromium.org/140693016/diff/1/Source/bindings/scripts/unstable/v8_interface.py#newcode527 ...
6 years, 10 months ago (2014-01-30 11:01:47 UTC) #4
Nils Barth (inactive)
On 2014/01/30 11:01:47, haraken wrote: > I see. Thanks for the clarification! n/p! (^.-)v
6 years, 10 months ago (2014-01-30 11:09:40 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-03 06:37:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/140693016/50001
6 years, 10 months ago (2014-02-03 06:37:45 UTC) #7
commit-bot: I haz the power
Change committed as 166290
6 years, 10 months ago (2014-02-03 06:38:00 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 06:38:00 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 06:38:05 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 06:38:06 UTC) #11
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698