Chromium Code Reviews| Index: sdk/lib/io/process.dart |
| diff --git a/sdk/lib/io/process.dart b/sdk/lib/io/process.dart |
| index a59fc88d8b4e089926c392e8b91dfdbbceb39538..455a4f2e9cda294431fadff03e71b6cc0652821d 100644 |
| --- a/sdk/lib/io/process.dart |
| +++ b/sdk/lib/io/process.dart |
| @@ -97,7 +97,7 @@ abstract class Process { |
| * |
| * On Linux and Mac a normal exit code will be a positive value in |
| * the range [0..255]. If the process was terminated due to a signal |
| - * the exit code will be a negative value in the range [-255..0[, |
| + * the exit code will be a negative value in the range [-255..0], |
|
Søren Gjesse
2014/01/16 19:05:03
0 should be excluded from the negative range here.
kevmoo
2014/01/18 00:56:56
Done.
|
| * where the absolute value of the exit code is the signal |
| * number. For example, if a process crashes due to a segmentation |
| * violation the exit code will be -11, as the signal SIGSEGV has the |
| @@ -254,16 +254,14 @@ abstract class Process { |
| int get pid; |
| /** |
| - * On Windows, [kill] kills the process, ignoring the [signal] |
| - * flag. On Posix systems, [kill] sends [signal] to the |
| - * process. Depending on the signal send, it'll have different |
| - * meanings. When the process terminates as a result of calling |
| - * [kill], the [exitCode] future is completed with the exit code. |
| + * On Linux and Mac OS, [kill] sends [signal] to the process. When the process |
|
Søren Gjesse
2014/01/16 19:05:03
sends [signal] -> sends the signal [signal]?
kevmoo
2014/01/18 00:56:56
Since it's referencing the parameter explicitly, I
|
| + * terminates as a result of calling [kill], the value for [exitCode] may be a |
|
Søren Gjesse
2014/01/16 19:05:03
Writing "the value for" for a future instead of "t
kevmoo
2014/01/18 00:56:56
Done.
|
| + * negative number corresponding to the provided [signal]. |
| * |
| - * Returns [:true:] if the process is successfully killed (the |
| - * signal is successfully sent). Returns [:false:] if the process |
| - * could not be killed (the signal could not be sent). Usually, |
| - * a [:false:] return value from kill means that the process is |
| + * On Windows, [kill] kills the process, ignoring the [signal] flag. |
| + * |
| + * Returns [:true:] if the signal is successfully sent and process is killed. |
| + * Otherwis the signal could not be sent, usually meaning that the process is |
|
Søren Gjesse
2014/01/16 19:05:03
Otherwis -> Otherwise
kevmoo
2014/01/18 00:56:56
Done.
|
| * already dead. |
| */ |
| bool kill([ProcessSignal signal = ProcessSignal.SIGTERM]); |