Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1406923010: Observe v= parameter when processing Alternative Services header. (Closed)

Created:
5 years, 1 month ago by Bence
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Observe v= parameter when processing Alternative Services header. BUG=539347 Committed: https://crrev.com/8be55ebb1121fd7fc77791a55ed1fa5c90cb1f66 Cr-Commit-Position: refs/heads/master@{#357094}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Re: #3. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M net/http/http_stream_factory.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 2 chunks +59 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thank you.
5 years, 1 month ago (2015-10-29 18:31:21 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/1406923010/diff/1/net/http/http_stream_factory.cc File net/http/http_stream_factory.cc (right): https://codereview.chromium.org/1406923010/diff/1/net/http/http_stream_factory.cc#newcode67 net/http/http_stream_factory.cc:67: match_found = true; Up to you, but instead ...
5 years, 1 month ago (2015-10-29 20:07:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406923010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406923010/20001
5 years, 1 month ago (2015-10-30 14:03:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 14:12:17 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 14:13:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8be55ebb1121fd7fc77791a55ed1fa5c90cb1f66
Cr-Commit-Position: refs/heads/master@{#357094}

Powered by Google App Engine
This is Rietveld 408576698