Issue 1406923006: Replace some LIBRARY_ELEMENTx dependency for closure with READY_LIBRARY_ELEMENTx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406923006: Replace some LIBRARY_ELEMENTx dependency for closure with READY_LIBRARY_ELEMENTx. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org, keertip

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Replace some LIBRARY_ELEMENTx dependency for closure with READY_LIBRARY_ELEMENTx. This helps to improve analysis time from about 39100 to 37000 ms. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4653d9bb76e8be1aeaf6db6f0fcdb9c8cd9d5d47

Patch Set 2 : Update comments. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -19 lines)			Patch
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	1	7 chunks	+147 lines, -11 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/driver.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/tool/task_dependency_graph/tasks.dot	View		7 chunks	+40 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1406923006/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1406923006/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode350 pkg/analyzer/lib/src/task/dart.dart:350: * The flag specifying that [LIBRARY_ELEMENT2] is ready ...

5 years, 1 month ago (2015-10-23 21:50:55 UTC) #2

scheglov

5 years, 1 month ago (2015-10-23 21:56:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4653d9bb76e8be1aeaf6db6f0fcdb9c8cd9d5d47 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1406923006: Replace some LIBRARY_ELEMENTx dependency for closure with READY_LIBRARY_ELEMENTx. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Update comments. #

Messages