src/ic/ic.cc - Issue 1406873002: [IC] Ensure we don't transition receivers when there's a data property in the hidden prototype chai…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1406873002: [IC] Ensure we don't transition receivers when there's a data property in the hidden prototype chai… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 3c7c6d36da9475dfacebbf952377bb524c1bd31d..80651b1588e0a14e1575e6cd2d6a252fc2cbbcfd 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1489,6 +1489,8 @@ bool StoreIC::LookupForWrite(LookupIterator* it, Handle<Object> value,

PrototypeIterator::GetCurrent(iter));

}

+ if (it->HolderIsReceiverOrHiddenPrototype()) return false;

it->PrepareTransitionToDataProperty(value, NONE, store_mode);

return it->IsCacheableTransition();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »