Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1406873002: [IC] Ensure we don't transition receivers when there's a data property in the hidden prototype chai… (Closed)

Created:
5 years, 2 months ago by Toon Verwaest
Modified:
5 years, 2 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[IC] Ensure we don't transition receivers when there's a data property in the hidden prototype chain. BUG=chromium:542647 R=cbruni@chromium.org LOG=n Committed: https://crrev.com/51cb4481a9bd1aff4c38f775b9e502eeb2c71642 Cr-Commit-Position: refs/heads/master@{#31357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/ic/ic.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Toon Verwaest
ptal
5 years, 2 months ago (2015-10-15 12:43:27 UTC) #1
Camillo Bruni
lgtm
5 years, 2 months ago (2015-10-15 14:17:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406873002/1
5 years, 2 months ago (2015-10-15 15:21:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6712)
5 years, 2 months ago (2015-10-15 15:23:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406873002/1
5 years, 2 months ago (2015-10-19 08:08:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 08:29:42 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 08:29:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51cb4481a9bd1aff4c38f775b9e502eeb2c71642
Cr-Commit-Position: refs/heads/master@{#31357}

Powered by Google App Engine
This is Rietveld 408576698