Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3511)

Unified Diff: build/standalone.gypi

Issue 1406843002: Add experimental support for compiling with clang and ASan on Linux. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« DEPS ('K') | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index c0eaef419df30e2ff6538aed44e0940d87aa128d..d012e7501344b466dce769fa9aa5fb74d8b1792e 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -8,6 +8,8 @@
'variables': {
'component%': 'static_library',
'clang%': 0,
+ 'asan%': 0,
+ 'sanitizer_coverage%': 0,
'msvs_multi_core_compile%': '1',
'variables': {
'variables': {
@@ -36,7 +38,9 @@
},
'host_arch%': '<(host_arch)',
'target_arch%': '<(target_arch)',
+ 'base_dir%': '<!(cd <(DEPTH) && python -c "import os; print os.getcwd()")',
Nico 2015/10/15 23:41:22 I don't think you need this…build/common.gypi does
Oliver Chang 2015/10/16 00:52:15 Ah, I based this off v8's standalone.gypi, but I g
},
+ 'clang_dir%': '<(base_dir)/third_party/llvm-build/Release+Asserts',
Nico 2015/10/15 23:41:22 try removing the <(base_dir)/ prefix here
Oliver Chang 2015/10/16 00:52:15 Done.
# These two are needed by V8.
'host_arch%': '<(host_arch)',
'target_arch%': '<(target_arch)',
@@ -161,6 +165,22 @@
'ldflags': [
'-pthread',
],
+ 'conditions': [
+ ['asan==1', {
+ 'cflags': [
+ '-fsanitize=address',
+ '-gline-tables-only',
+ ],
+ 'ldflags': [
+ '-fsanitize=address',
+ ],
+ }],
+ ['sanitizer_coverage!=0', {
+ 'cflags': [
+ '-fsanitize-coverage=<(sanitizer_coverage)',
+ ],
+ }],
+ ],
'defines': [
# Don't use deprecated V8 APIs anywhere.
'V8_DEPRECATION_WARNINGS',
@@ -250,6 +270,16 @@
'-fPIC',
],
}],
+ ['OS=="linux"', {
Nico 2015/10/15 23:41:22 don't you want this on mac too? actually, shouldn
Lei Zhang 2015/10/16 00:23:16 I don't build on Mac much, but I suppose we should
Oliver Chang 2015/10/16 00:52:15 I don't have a Mac to test this on, but I guess it
+ 'conditions': [
+ ['clang==1', {
+ 'make_global_settings': [
+ ['CC', '<(clang_dir)/bin/clang'],
+ ['CXX', '<(clang_dir)/bin/clang++'],
+ ],
+ }],
+ ],
+ }], # OS=="linux"
['OS=="win"', {
'target_defaults': {
'defines': [
« DEPS ('K') | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698