Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: src/lithium-codegen.cc

Issue 140683011: Improve positions tracking inside the HGraphBuilder. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 if (FLAG_code_comments && instr->HasInterestingComment(codegen)) { 100 if (FLAG_code_comments && instr->HasInterestingComment(codegen)) {
101 Comment(";;; <@%d,#%d> %s", 101 Comment(";;; <@%d,#%d> %s",
102 current_instruction_, 102 current_instruction_,
103 instr->hydrogen_value()->id(), 103 instr->hydrogen_value()->id(),
104 instr->Mnemonic()); 104 instr->Mnemonic());
105 } 105 }
106 106
107 GenerateBodyInstructionPre(instr); 107 GenerateBodyInstructionPre(instr);
108 108
109 HValue* value = instr->hydrogen_value(); 109 HValue* value = instr->hydrogen_value();
110 if (value->position() != RelocInfo::kNoPosition) { 110 if (!value->position().IsUnknown()) {
111 ASSERT(!graph()->info()->IsOptimizing() || 111 RecordAndWritePosition(
112 !FLAG_emit_opt_code_positions || 112 chunk()->graph()->SourcePositionToScriptPosition(value->position()));
113 value->position() != RelocInfo::kNoPosition);
114 RecordAndWritePosition(value->position());
115 } 113 }
116 114
117 instr->CompileToNative(codegen); 115 instr->CompileToNative(codegen);
118 116
119 GenerateBodyInstructionPost(instr); 117 GenerateBodyInstructionPost(instr);
120 } 118 }
121 EnsureSpaceForLazyDeopt(Deoptimizer::patch_size()); 119 EnsureSpaceForLazyDeopt(Deoptimizer::patch_size());
122 last_lazy_deopt_pc_ = masm()->pc_offset(); 120 last_lazy_deopt_pc_ = masm()->pc_offset();
123 return !is_aborted(); 121 return !is_aborted();
124 } 122 }
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 for (int i = 0; i < objects.length(); i++) { 186 for (int i = 0; i < objects.length(); i++) {
189 AddWeakObjectToCodeDependency(isolate()->heap(), objects.at(i), code); 187 AddWeakObjectToCodeDependency(isolate()->heap(), objects.at(i), code);
190 } 188 }
191 for (int i = 0; i < cells.length(); i++) { 189 for (int i = 0; i < cells.length(); i++) {
192 AddWeakObjectToCodeDependency(isolate()->heap(), cells.at(i), code); 190 AddWeakObjectToCodeDependency(isolate()->heap(), cells.at(i), code);
193 } 191 }
194 } 192 }
195 193
196 194
197 } } // namespace v8::internal 195 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698