third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-event-type-worker.js - Issue 1406823002: Start of foreign fetch implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-event-type-worker.js

Issue 1406823002: Start of foreign fetch implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unit test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/service_worker/service_worker_messages.h ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/register-foreign-fetch-errors.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/register-foreign-fetch-errors-worker.js » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/register-foreign-fetch-errors-worker.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-event-type-worker.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-event-type-worker.js b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-event-type-worker.js

index d729afa090cfd7c927525b22d0012896d5988a3c..6f936a0063e159667202ded493ac6532624a48d5 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-event-type-worker.js

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-event-type-worker.js

@@ -2,6 +2,7 @@ importScripts('worker-testharness.js');

self.oninstall = function(event) {

assert_true(event instanceof ExtendableEvent);

+ assert_true(event instanceof InstallEvent);

falken 2015/10/16 11:58:43 Hm, I was a bit worried this expectation changes e

Marijn Kruisselbrink 2015/10/16 17:23:24 Yeah, the version of global-interface-listing-serv

assert_equals(event.type, 'install');

assert_false(event.cancelable);

assert_false(event.bubbles);