Issue 1406813002: Remove include_subdomains from branchtrack.com.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406813002: Remove include_subdomains from branchtrack.com. (Closed)

Created:
5 years, 2 months ago by lgarron

Modified:
5 years, 2 months ago

Reviewers:

CC:
cbentzel+watch_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove include_subdomains from branchtrack.com. Reason given: branchtrack.com is "using tumblr with subdomain, but it's not supported over https." BUG=527947 TBR=agl@chromium.org Committed: https://crrev.com/cf50d03e45e9eb3a8dd21b2594bd11af287e2fc3 Cr-Commit-Position: refs/heads/master@{#354126}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/http/transport_security_state_static.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/http/transport_security_state_static.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406813002/1

5 years, 2 months ago (2015-10-14 20:43:49 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-14 22:02:25 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cf50d03e45e9eb3a8dd21b2594bd11af287e2fc3
Cr-Commit-Position: refs/heads/master@{#354126}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages