Issue 1406733003: Declare the random number generator lambda for std::random_shuffle as a local.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406733003: Declare the random number generator lambda for std::random_shuffle as a local. (Closed)

Created:
5 years, 2 months ago by Robert Sesek

Modified:
5 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Declare the random number generator lambda for std::random_shuffle as a local. When not building against the C++11 library headers, the compiler cannot treat the lambda as lvalue. When building against the C++11 library headers, it is converted to an rvalue. BUG=chromium:542321 R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1f1a24cb51444ee1c5fe9efb20bf870e84a9c620

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	client/prune_crash_reports_test.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Robert Sesek

5 years, 2 months ago (2015-10-14 23:56:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1f1a24cb51444ee1c5fe9efb20bf870e84a9c620 (presubmit successful).