Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 140673004: Merged r18754 into 3.22 branch. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r18754 into 3.22 branch. Ensure we don't overwrite transitions in SetPropertyIgnoreAttributes. BUG=326155 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
6 years, 10 months ago (2014-01-29 15:04:43 UTC) #1
Jakob Kummerow
lgtm
6 years, 10 months ago (2014-01-29 15:05:40 UTC) #2
Toon Verwaest
6 years, 10 months ago (2014-01-29 15:06:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18914.

Powered by Google App Engine
This is Rietveld 408576698