Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14067009: drive: Call LoadIfNeeded before CreateDirectory. (Closed)

Created:
7 years, 8 months ago by kinaba
Modified:
7 years, 8 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Call LoadIfNeeded before CreateDirectory. We have the guard by LoadIfNeeded for GetEntryInfoByPath and ReadDirectory. In most of the cases those two functions are the entry points to Drive, but in some cases CreateDirectory is the lead-off batter. BUG=231384 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195981

Patch Set 1 : #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kinaba
ptal.
7 years, 8 months ago (2013-04-23 04:15:16 UTC) #1
hashimoto
lgtm
7 years, 8 months ago (2013-04-23 04:25:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14067009/2018
7 years, 8 months ago (2013-04-23 04:27:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14067009/12001
7 years, 8 months ago (2013-04-23 07:14:02 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-23 10:18:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14067009/12001
7 years, 8 months ago (2013-04-23 10:52:50 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-23 12:22:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14067009/12001
7 years, 8 months ago (2013-04-23 13:04:09 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-23 14:21:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14067009/29001
7 years, 8 months ago (2013-04-24 00:45:18 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-24 00:46:29 UTC) #11
kinaba
7 years, 8 months ago (2013-04-24 01:48:30 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 manually as r195981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698