Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 14067008: Update dummy compiler with new interceptor-related methods (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/utils/dummy_compiler_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
index 06cbf98a637f7abde500ec9e487a2592c6f3d5b4..98e41ed1b94f72e9cf0b324852179fa8bca0b4e1 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
@@ -872,9 +872,9 @@ class JavaScriptBackend extends Backend {
compiler.findHelper(const SourceString('defineNativeMethodsFinish'));
// These methods are overwritten with generated versions.
- forbidInlining(getInterceptorMethod);
- forbidInlining(getDispatchPropertyMethod);
- forbidInlining(setDispatchPropertyMethod);
+ canBeInlined[getInterceptorMethod] = false;
+ canBeInlined[getDispatchPropertyMethod] = false;
+ canBeInlined[setDispatchPropertyMethod] = false;
List<ClassElement> classes = [
jsInterceptorClass =
@@ -949,14 +949,6 @@ class JavaScriptBackend extends Backend {
validateInterceptorImplementsAllObjectMethods(jsInterceptorClass);
}
- void forbidInlining(Element element) {
- // This guard is needed because the backend is initialized even for
- // --analyze-only compiles which skip some helper libraries.
- if (element is FunctionElement) {
- canBeInlined[element] = false;
- }
- }
-
void validateInterceptorImplementsAllObjectMethods(
ClassElement interceptorClass) {
if (interceptorClass == null) return;
« no previous file with comments | « no previous file | tests/utils/dummy_compiler_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698