Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1406633002: Add window type launcher app. Nothing really works right now since WM/mus don't support anything (Closed)

Created:
5 years, 2 months ago by Ben Goodger (Google)
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wm2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add window type launcher app. Nothing really works right now since WM/mus don't support anything R=sky@chromium.org BUG=none Committed: https://crrev.com/111bf596f6eea3e86ded5e9f4fe0045bdfba2ec9 Cr-Commit-Position: refs/heads/master@{#353915}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -18 lines) Patch
M components/mus/example/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + components/mus/example/window_type_launcher/BUILD.gn View 1 2 3 3 chunks +7 lines, -5 lines 0 comments Download
A + components/mus/example/window_type_launcher/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/mus/example/window_type_launcher/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/mus/example/window_type_launcher/window_type_launcher.h View 3 chunks +12 lines, -12 lines 0 comments Download
A components/mus/example/window_type_launcher/window_type_launcher.cc View 1 2 3 1 chunk +396 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Ben Goodger (Google)
5 years, 2 months ago (2015-10-13 20:44:51 UTC) #1
sky
LGTM
5 years, 2 months ago (2015-10-13 21:32:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406633002/20001
5 years, 2 months ago (2015-10-13 22:48:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/93429) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-10-13 23:01:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406633002/40001
5 years, 2 months ago (2015-10-13 23:13:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/93443) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-10-13 23:20:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406633002/60001
5 years, 2 months ago (2015-10-13 23:29:21 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-14 00:00:57 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 00:02:22 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/111bf596f6eea3e86ded5e9f4fe0045bdfba2ec9
Cr-Commit-Position: refs/heads/master@{#353915}

Powered by Google App Engine
This is Rietveld 408576698