Avoids releasing pointer grab prematurely

ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h"
 
 #include <X11/Xlib.h>
 // Get rid of a macro from Xlib.h that conflicts with Aura's RootWindow class.
 #undef RootWindow
 
@@ skipping 75 matching lines @@
   }
 
   return true;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // DesktopWindowTreeHostLinux, aura::client::WindowMoveClient implementation:
 
 bool X11WholeScreenMoveLoop::RunMoveLoop(aura::Window* source,
                                          gfx::NativeCursor cursor) {
-  // Start a capture on the host, so that it continues to receive events during
-  // the drag.
-  ScopedCapturer capturer(source->GetDispatcher()->host());
+  {
+    // A capture is started on the host, so that it continues to receive events
+    // during the drag.
+    ScopedCapturer capturer(source->GetDispatcher()->host());
 
-  DCHECK(!in_move_loop_);  // Can only handle one nested loop at a time.
-  in_move_loop_ = true;
+    DCHECK(!in_move_loop_);  // Can only handle one nested loop at a time.
+    in_move_loop_ = true;
 
-  XDisplay* display = gfx::GetXDisplay();
+    XDisplay* display = gfx::GetXDisplay();
 
-  grab_input_window_ = CreateDragInputWindow(display);
-  if (!drag_image_.isNull())
-    CreateDragImageWindow();
-  base::MessagePumpX11::Current()->AddDispatcherForWindow(
-      this, grab_input_window_);
-
+    grab_input_window_ = CreateDragInputWindow(display);
+    if (!drag_image_.isNull())
+      CreateDragImageWindow();
+    base::MessagePumpX11::Current()->AddDispatcherForWindow(
+        this, grab_input_window_);
+    // Releasing ScopedCapturer ensures that any other instance of
+    // X11ScopedCapture will not prematurely release grab that will be acquired
+    // below.

[sadrul, 2014/02/06 19:14:46]

I do not understand what this means. Mind explaining with more detail?

The capture is meant to persist during the entire drag. Releasing the capture
early here seems wrong?

[varkha, 2014/02/06 19:22:55]

There are three points where we set capture, all three are involved. The first
point is when DesktopWindowTreeHostX11::SetCapture is called. The second is
ScopedCapturer which releases that capture and sets another and the third is
GrabPointerWithCursor which releases that and grabs another one. This one is
supposed to stay through the drag. It gets broken when one tab looses focus (and
another one gains focus). When that happens the 
DesktopWindowTreeHostX11::OnNativeWidgetBlur releases capture and that is the
same capture as the one obtained last (in GrabPointerWithCursor). The result is
that mouse events are no longer reaching the drag input window.

Limiting the scope causes the capture in DesktopWindowTreeHostX11 (pointed by
x11_capture_ member there) to get released which then allows OnNativeWidgetBlur
to avoid releasing the capture.

[sadrul, 2014/02/07 00:08:37]

In the context of a drag, who calls this first SetCapture()? I suppose it's done
by Widget in response to the mouse-press event?
A DesktopWindowTreeHostX11 is supposed to receive events only directed to its
|xwindow_|. When the grab happens on |grab_input_window_|, do we get a FocusOut
X-event directed to |xwindow_|? I guess if this happens, then X11ScopedCapture
should not reset the grab in such situations.

If we reset the capture (i.e. the one from ScopedCapture) here and things work,
does it make any difference if we just don't hold the capture (i.e. don't use
ScopedCapture) in the first place?

+  }
   if (!GrabPointerWithCursor(cursor))
     return false;
 
   // We are handling a mouse drag outside of the aura::RootWindow system. We
   // must manually make aura think that the mouse button is pressed so that we
   // don't draw extraneous tooltips.
   aura::Env* env = aura::Env::GetInstance();
   if (!env->IsMouseButtonDown()) {
     env->set_mouse_button_flags(ui::EF_LEFT_MOUSE_BUTTON);
     should_reset_mouse_flags_ = true;
@@ skipping 115 matching lines @@
   image->SetBounds(0, 0, drag_image_.width(), drag_image_.height());
   widget->SetContentsView(image);
 
   widget->Show();
   widget->GetNativeWindow()->layer()->SetFillsBoundsOpaquely(false);
 
   drag_widget_.reset(widget);
 }
 
 }  // namespace views