Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: Source/bindings/scripts/unstable/v8_types.py

Issue 140663012: IDL compiler: Window-specific code + Window-only features (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No headers for named constructor attributes Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/unstable/v8_types.py
diff --git a/Source/bindings/scripts/unstable/v8_types.py b/Source/bindings/scripts/unstable/v8_types.py
index ecd99d8d8bc7b2eb84e893fa5ee0e945a82f0634..03326140ba04679e651d3b9498fa1ca75ca84b74 100644
--- a/Source/bindings/scripts/unstable/v8_types.py
+++ b/Source/bindings/scripts/unstable/v8_types.py
@@ -382,6 +382,11 @@ def includes_for_type(idl_type):
return set.union(*[
includes_for_type(union_member_type)
for union_member_type in idl_type.union_member_types])
+ if idl_type.endswith('ConstructorConstructor'):
haraken 2014/02/06 07:57:44 This looks ugly. Can we rename it to NamedConstruc
Nils Barth (inactive) 2014/02/06 08:40:14 Agreed, it's hideous - I'd be delighted to fix thi
+ # Ending with 'ConstructorConstructor' indicates a named constructor,
+ # and these do not have header files, as they are part of the generated
+ # bindings for the interface
+ return set()
if idl_type.endswith('Constructor'):
idl_type = constructor_type(idl_type)
return set(['V8%s.h' % idl_type])

Powered by Google App Engine
This is Rietveld 408576698